Hey avil, just want to say that i can't live without this mod now. I could provide you with a polish translation if you'd like. Don't want to write and essay about this here, so respond if you'd like me to provide one and i'll check back later

Sure. Just make a push request on github for it (that way you also will be able to maintain it). I"ll be able to actually add in only the next month, though, because my tools will not be available until then (I'm on vacation).

So one of the suggestions that I really liked the sound of was keeping pawns that are not "cleaners" from doing opportunistic cleaning. A simple check to see if they are capable of cleaning (via work settings?) before assigning the job?

Oprindeligt skrevet af lilwhitemouse:

So one of the suggestions that I really liked the sound of was keeping pawns that are not "cleaners" from doing opportunistic cleaning. A simple check to see if they are capable of cleaning (via work settings?) before assigning the job?

Pawns, that not assigned to cleaning, don't do it already :)

Well. I had thought I saw that happening, but apparently not!

Okay, I DO see it happening when a pawn is doing a bill (and "cleaning in between gathering materials and starting to work" is checked) - my pawn Didi is incapable of cleaning, but she has gathered smokeleaf leaves and is now "Making smokeleaf joint" - but she has clearly walked away from the crafting spot to clean sand.

I guess that's a separate logic-path from the opportunistic cleaning? Either way, she is technically incapable of cleaning so she probably shouldn't be doing what she's doing.

Yes, she shouldn't. It's definitely a bug. I'm pretty sure they use the same piece of logic. I use a mod that introduces "hated" jobs, so I use logic that prevents pawns from using unassigned jobs, without checking incapability (because LOGICALLY they're always unassigned). Probably "not being assigned" and "not being able" isn't quite the same thing in Rimworld logic. Anyway, I'll investigate that.

You're probably right: not the same logic, altho one would think it would work just fine.... *facepalm* (It works for vanilla, so no one would notice, probably ;) )

Hello Avil,
I was wondering if it would be possible to add an option that would keep pawns from doing work in rooms where other pawns are currently sleeping?
As to avoid the disturbed sleep debuff from pawns just randomly cleaning or re-planting pots while other pawns try to get some rest.

That's a good idea.
I had it for awhile now, actually. I wanted to redo "wandering" to make it dramatically shorter and do something to pathing to avoid inappropriate routes.
Could as well adress all other jobs, when they're in "bedrooms".

Great mod, but I do have one request: prevent pawns who are patients/resting and/or bleeding from cleaning. Had a couple instances with a bleeding pawn waiting to be tended constantly getting up to clean their own blood, which was preventing me from tending the pawn.

Haha yes, I've had that too. "No, stop being OCD, just lie in the bed and let the good doctor patch you up! THEN you can clean if you must!" I suspect it's the way the game handles the "be a patient" job :p

Yeah, that's an issue with that I don't know, what they did previously. I have no clue, why would they just stop waiting to be tended from time to time, that's what triggers cleaning. Maybe I just should ignore opportunistic tasks when pawns need tending or surgery.

If you search the tree of WorkGrivers and JobDrivers, the basic job is JobDefOf.LayDown (See RimWorld/JobGiver_PatientGoToBed.cs). If you look at RimWorld/Toils_LayDown.cs, there is:

if (lookForOtherJobs && actor.IsHashIntervalTick(211))
{
actor.jobs.CheckForJobOverride();
return;
}

So every so often, the pawn checks to see what they should be doing, and then decides they should be lying in bed....which triggers the cleaning.

You might use some of the logic from Toils_LayDown.cs to check if the pawn is in bed already before allowing opportunistic cleaning?

(I was pretty sure there was a check like that in there somewhere)