Conflict with Outfit Stands Plus

Exception drawing OutfitStandsPlus_MechanizedOutfitStand3454282:
System.NullReferenceException: Object reference not set to an instance of an object

at OdysseyPatch.OutfitStandBodyType.Patch_Building_OutfitStand_DrawAt.GetOutfitStandGraphic (RimWorld.Building_OutfitStand stand)
at RimWorld.Building_OutfitStand.DrawAt (...)
- TRANSPILER odysseypatch.1trickPwnyta
- POSTFIX OskarPotocki.VEF (Vanilla Expanded Framework)

Now we need the vanilla patch

@JoeOwnage I haven't made one yet, but I do have plans for it eventually.

Did you used to have a royalty patch or am I crazy

@Cal I found the performance issue you mentioned and fixed it in today's update. Thanks!

@Poindexter1985 I was able to reproduce this behavior, but the mod order did matter for me. I was using only Harmony, Improved Map Search, its dependency, and this mod. With this mod loaded after Improved Map Search, the search results were not grouped. However, with this mod loaded before Improved Map Search, the search results were grouped. I have updated the mod to enforce the correct load order for these mods. Please let me know if you still have trouble with the new version. Thanks!

There is still something not quite right. Not sure if its a mod conflict of some sort, but

OdysseyPatch.ShuttleFood.Patch_JobGiver_TakeDrugsForDrugPolicy_FindDrugFor:Postifx

is at the top of the list for frame time in analyzer.

https://gist.github.com/HugsLibRecordKeeper/96d1c103687633c20e40e613f3622fc6

Above is a HugsLib export taken just after starting a dev quicktest colony and searching the map.

This is a screenshot that shows that the search results not being improved by Improved Map Search. The search results are supposed to be displayed in collapsible groups, but they are not. https://imgur.com/a/5lIPclg

Load order does not seem to matter. I've tried with Improved Map Search loaded both before and after your mod. I've also tried with your map search option disabled and enabled. In all cases, Improved Map Search grouping does not work.

It's working now! I can see the button perfectly. Thanks for the quick fix!

If you asking me - yes the whole serch menu replaced by your mod. Moreover search dont work - it didnt find anything. I loaded this mod after IMS, cant tell more cos not at my home PC.

@1trickPwnyta, no errors were generated. I'll try later and grab a log export in case there's anything useful.

As for what part of Improved Map Search breaks - the core functionality? When this was installed, map search results were no longer grouped.

Thanks for answer.

@veoba You could also try changing the order of the two mods, or disable that feature in this mod. It can be disabled individually in the mod settings.

@1trickPwnyta
i also use this mod
https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=3547866455
and after adding this one the global mapsearch overriding by yours. i disabled only this mod from my big modlist and the problem is gone.

Yea, this has some funky overhead at the moment. Going to have to let it cook a bit longer.

@Poindexter1985 I tried using Improved Map Search with this mod and didn't find any issues. Do you have any logs that show the error(s)? What part of the mod breaks, exactly? Thanks!

@Mr. Clavicus @翌原点 I just posted version 1.0.3 with an additional check that should hopefully resolve any remaining issues with shuttles. Let me know if you still have trouble. Thanks!

@Mr. Clavicus I put out an update yesterday that should have fixed that. Can you confirm that you are on version 1.0.2 of the mod? It should show the version when you select the mod in your mod list.

Hey 1trick, I've found that if you have the option to pull things from the ship. it breaks all the mod shuttles at the moment. it makes them inaccessible to load/launch/anything. you can build more with dev but you can't do anything with them once they're there. once i disabled the new option you added, i can interact with the shuttle again

look like this mod will let “milira harrier fighter” of “milira race”mod can't show operate button。

System.NullReferenceException: Object reference not set to an instance of an object
[Ref E3A6BB3A]
at OdysseyPatch.ShuttleFood.Patch_Building_PassengerShuttle+<>c__DisplayClass0_0.<Postfix>b__0 () [0x0000b] in <b3286e5189f447c48319480a9c4c7099>:0
at Verse.GizmoGridDrawer.DrawGizmoGrid (System.Collections.Generic.IEnumerable`1[T] gizmos, System.Single startX, Verse.Gizmo& mouseoverGizmo, System.Func`2[T,TResult] customActivatorFunc, System.Func`2[T,TResult] highlightFunc, System.Func`2[T,TResult] lowlightFunc, System.Boolean multipleSelected) [0x0025a] in

1. After testing, when the "Drag Food on Shuttle" function is disabled, the issue of "people not feeding others and standing idle" still persists.
2. It was further found that when delivering food to mobile prisoners, the relevant personnel also stand idle and remain motionless.
3. When this function is disabled, only the scenario of "people eating food by themselves" works normally.
4. However, during "feeding others" or "delivering food to others", the relevant personnel will directly stand idle at the stage of "obtaining food".
5. When the "Drag Food on Shuttle" function is enabled, all the aforementioned issues disappear completely.

@1trickPwnyta
1. No one is attempting to feed infants on the map.
2. Eating food by themselves is normal; issues only occur when feeding patients or prisoners. (I suspect that feeding infants with food may also cause them to stand idle.)
3. The old save file has a modified shuttle, while the newly created test save file does not. However, the same issue still occurs in both.
4. I noticed the update and will test it as soon as I have time.

The issue of characters standing idle without being fed only happens when the "Drag Food on Shuttle" function is disabled. There are no problems at all when this function is enabled. If you fix the compatibility with other shuttle mods, I would be happy to keep this option enabled. However, I will first test whether the issue still occurs after disabling this function.

@1trickPwnyta Testcase at https://limewire.com/?referrer=pq7i8xx7p2 (valid for 7 days), simply remove something from the stand.

@yavis I have some questions, if you don't mind:
1. Is there a baby on the map somewhere that colonists might be trying to feed?
2. Are people able to eat food themselves and only can't feed others, or can nobody eat anything at all?
3. You said you have no vanilla shuttles on your map. Are there any modded ones?
4. I made an update today that may or may not be related. Did this resolve your issue by any chance?

Just published an update making modded shuttles compatible with the shuttle supplies feature. It should work for any modded shuttle that uses the Building_PassengerShuttle class. Those that don't use that class should still work normally, just without the feature added. I confirmed this works at least with the Stealth Shuttle mod.

@llunak The log you posted seems to be the trace for when an item is added to the outfit stand, not removed. Would you be able to post the full log file? I am unfortunately unable to reproduce this behavior on my end.

Can you patch anti-toxic lungs so colonist with this gene don't suffer mood debuff from tox water.
If it's not too much to ask could you also make it so colonist with anti-toxic lungs can perform the swimming recreation activity in toxic lakes?

outfit stands allowing for different bodytypes? HELL YEA

perfection.

Damn, most of those change should just be vanilla.
Sometimes I wonder if the devs actually play their games.

I'm going to look into the modded shuttles thing tonight and see if I can fix it real quick.

Agree with others that having this mod enabled seems to make any modded shuttles (such as ultra tech shuttle, stealth shuttle, mechanitor shuttle, etc.) no longer usable as their UI completely disappears. Hoping this can be fixed!

@yavis I have the same issue,and if enable the feature,my aircraft in Milira Race will lost all control button(maybe because it's a shuttle too)

This mod causes the pumpkin spaceship in "Giant Crop Ex" and the nanoshuttles in "[HYE] Nanotech Overpower" and similar spaceships to not function properly; simply removing this mod will fix the issue.

This mod causes items dropped from outfit stands to disappear.

If there is a stand in a room that's full of items, and I select the stand, click 'Contents' and click the drop icon button next to a piece of apparel, without this mod it appears somewhere on the ground, even outside the room. With the mod, the item disappears, with this stacktrace: https://pastebin.com/Vi9wpqpP

1. When this issue occurs, no information pops up in the log. The Pawns just stand around idle. Then, prisoners who need to be fed or colonists who have fallen ill will keep starving until they die.
2. I checked the JobGiver via the Dubs Performance Analyzer mod, and the idle-standing Pawns are executing the Autofeed task.
3. After enabling the feature "Pawns can grab food, medicine, and drugs from their parked shuttle just like they can from their pack animals" in the game settings, all the issues are resolved.

First of all, thank you. If it's troublesome to handle this issue, you don't have to worry about it—after all, using so many mods is always only done by a small number of people (like me).

https://gist.github.com/HugsLibRecordKeeper/3f4b747fdb8c3c0dffb6251d17c9bf9f

@yavis Do you have HugsLib installed by any chance? If so, can you please do a Ctrl+F12 (on the game menu screen is fine) and send me the link it gives you? If you don't have HugsLib, let me know.

🥳

@yavis When I get home I'm going to find a way to get the log data we need to resolve this.

Additional information about the issue encountered:
1: There was no vanilla shuttle in my original save file.
2: When using the mod elimination process, I used the quick test function, and there was no shuttle at all in this process.

is there a mod that lets you grab food/meds/etc from vehicle framework vehicles? Just like with the shuttle, it's annoying having to drop stuff on the ground so it can be used. Especially the refridgerated truck.

It was precisely because there were no error pop-ups at all that I had to use the mod elimination process—and it took me quite a bit of time to troubleshoot the issue. After identifying the root cause, the problem was resolved right away as soon as I enabled the option.

There will be no logs at all, and the Pawns will stand completely still without moving.

@yavis It's working for me when I disable the setting. Maybe it's a mod conflict? Are there any errors in the log when this happens for you?

"Pawns can grab food, medicine, and drugs from a parked shuttle, just as they can from a pack animal. This can be toggled via shuttle gizmo."

If this feature is disabled, it will cause all of the Pawns' feeding tasks to completely fail, and the Pawns will stand idle indefinitely. I have over 400 mods installed, and it took me a long time to identify this issue through the process of elimination.

@Poindexter1985 I'll see if I can fix that. Thanks!

This mod seems to break the Improved Map Search mod when installed. I'm guessing that this is related to your world search option, but the incompatibility remains whether the option is toggled on or off in your mod.

There seems to be an error with the mechanitor shuttle from the "Odyssey Transport Shuttle" mod. Still testing but it may need a patch.

@Cal Okay I made a dumb mistake which caused those errors. I just updated, so it should work now.