Victorious revolutions in vanilla will now revert their capital back to its historical location but outside that, ai nations wont revert to their historical capital location if it is reconquered. If you don't care about that niche situation then this mod is no longer needed :)

is this still needed or did paradox fix this?

Easy enough to do! Will implement as a game rule when I get the chance :)

Might be a general problem I am having with my PC, but I noticed a drop in performances after installing this mod. Do you think it would be possible to change the frequency to a yearly one? I have little modding knowledge but I can try if you can tell me where to look at. Thanks!

Must have, thanks alot

Primarily to ensure game and mod compatibility, but also to cover (granted, very rare) situations where a tag loses a capital in a diplo play and regains it through conquest

Is there any particular advantage to checking the country definitions + having hard-coded edge cases as opposed to just saving the current capital and market capital as variables in the on_revolution_start on action and resetting them after the war ends with on_civil_war_won ? Doing it this way through the on actions would make it completely agnostic to who the country is and should have no edge cases.

Gotcha, changed in the new version. Thanks!

Also Qing's Market Capital is in Guandong not Beijing. Forgot about that one as well. Everyone else's capital and market capital should be the same.

Ah, good catch - I wasn't aware the market capital was in a different place. Should be fixed now!

set_market_capital = STATE_DISTRICT_OF_COLUMBIA. USA's market capital is in New York, you do NOT want to move it to DC that would be a disaster.

New update now also reverts the market capital and will revert the capital of Germany to the capital of the nation that formed it. Thanks for the suggestions!

Really don't know why Paradox didn't add a post-war check for this.

Exactly yes - whilst not supported currently, it's a good idea and something I'll look into when I next update

@Fossil.21 I haven't tried it out but looking at the code Germany's capital will be set to Berlin as long as Germany controls that state. It does not take into account who formed it.
Easiest way to fix that would be to set a variable based on who formed Germany using on_country_formed on_action, or alternatively set it inside german_unification.4 event (it is triggered when Germany is formed), and then the mod's event file will check if you have for example prussia_formed_ger or austria_formed_ger variable and moves the capital to either Berlin or Vienna (if possible).

Does this mod cover market capitals as well

Oh I just thought, how does this mod handle Germany's capital? If Austria forms Germany, do they move the capital to Berlin (which wouldn't make sense)?

awesome, thanks!

Not to my knowledge - the check only occurs once a month at the end of every month, typically when the game saves. Italy changing its capital to Rome is indeed covered here :)

does this affect performance? Also may I suggest a mod for Italy to move its capital to Rome?