Steam Community :: Tome of Memory Loss

Store Page

Elin

All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

Elin > Workshop > grueshanker's Workshop

Tome of Memory Loss

Description Discussions0 Comments37 Change Notes

Showing 1-10 of 13 entries

< 1 2 >

Update: 7 Sep @ 12:36am

THE BUG:
- Two systems conflicted: innate abilities (from race/job data) and learned spells (from the element system).
- Tracking spell removals needed to survive both game reloads and ability refresh calls.
- Re-learning detection was broken: if a spell was removed and later learned again, it stayed invisible.

THE CORE PROBLEMS:

1. "Ghost Spell" Bug: Removed spell → NPC learned it again → spell stayed invisible in the tome UI.
2. Innate vs Learned Detection: The same spell could be both innate and learned at once.
3. Refresh Persistence: CharaAbility.Refresh() would undo removals and restore spells.

THE HOTFIX:

1. Hybrid Detection System

- Old approach: Directly used source data, which meant innate abilities could never be removed.
- New approach: Read abilities from `list.items`, but classify correctly:
- Learned abilities → check `_listAbility` and use real charges from `chara.elements`.
- Innate abilities → classified with no fake charges.

------------------------------------------------------------------------
// AFTER: Hybrid classification
bool isLearned = IsInLearnedList(chara, spell.id);
if (isLearned) {
element = chara.elements.GetElement(spell.id);
} else {
element = null; // Innate ability
}
------------------------------------------------------------------------

2. PersistentAbilityTracker with Re-Learning Detection

* Added removal tracking that persists across refreshes and reloads.
* When Refresh is called:
* If a spell should stay removed but is found in `chara.elements.dict`, it means the NPC actually re-learned it. In that case, we stop tracking removal.
* Otherwise, the removal persists.

------------------------------------------------------------------------
if (PersistentAbilityTracker.ShouldRemainRemoved(chara, spell.id)) {
if (chara.elements.dict.ContainsKey(spell.id)) {
PersistentAbilityTracker.UntrackRemoval(chara, spell.id);
} else {
__instance.list.items.RemoveAt(i);
}
}
------------------------------------------------------------------------

3. Cross-Mod Synchronization

* Used `BaseCard.mapObj` for persistence and cross-mod sync.
* Shared a unique storage key so NPCSpellFix and CustomAI always stay in sync.

------------------------------------------------------------------------
private const int MAGIC_NUMBER = 1337420069;
((BaseCard)chara).SetObj(MAGIC_NUMBER, removedAbilities);
------------------------------------------------------------------------

KEY ELIN CLASSES INVOLVED:

* `CharaAbility.Refresh()` – patched to keep removals intact.
* `chara.elements.dict` – holds learned spells and charges.
* `chara.ability.list.items` – the actual combat ability list.
* `chara._listAbility` – the internal learned ability list.
* `BaseCard.SetObj/GetObj<T>()` – persistence system for saving removals.
* `PersistentAbilityTracker` – custom tracker that makes the system reliable.

RESULT:

* Innate abilities can now be removed permanently.
* Learned spells show proper charges and are manageable.
* Re-learned spells reappear automatically.
* NPCSpellFix and CustomAI stay perfectly synchronized.
* Persistence works across saves and reloads.