I'm on it

Uploaded the fix, let me know if it still happens

Nothing changed, same errors spam

I've been trying to recreate the spam, with the mods that logged an error from what you showed me.
- My mod
- Yayo Combat + addons
- Dubs Bad Hygiene + DBH Hotsprings and patches
- Vanilla Psycasts
- Edge of Descension: Stuncaster 3.0
- [NL] Facial animations + it's addons (Paper Plane)
- Performance Optimizer

And I tried to use all of these mods' features, but couldn't get it to error.
So: It's definitely *not a compatibility error with Yayo's combat*, or any of the mods I tried to use with it

Most likely:
1. It's a mod sorting issue (I recommend using RimSort)
OR
2. Steam didn't update my mod for you (again, if you don't already, use RimSort)
OR
3. It's something else from your modlist (Which is huge from what I saw, so I can't really help unless I know which mod it is specifically, sorry)

edit: RimSort isn't 100% reliable, for example "EoD: StunCaster" doesn't have the proper sorting rules, but it has a steam update function to make sure your mods are up to date

I see. I am already using rimsort and manually unsub and resub to mods that get updated. Thanks for taking your time to look into it

Np, you have an impressive modlist lol. But yeah, unsubbing and resubbing doesn't update mods all of the time (steam issue). The "Update Workshop Mods" on the downloads tab in RimSort is more reliable

I don't know what you did, but the issue is gone now. So case closed i guess? Cool and good!

tbh I don't think I know what I did either, it's like I'm playing whack a mole with these bugs

Regarding the public execution glitch. Here's the visual exception being thrown when the neck wound fails to apply and the ceremony gets stuck. It references this mod, Vanilla Expanded Framework and related mods, and Yayo's Combat.

Exception in Verse.AI.JobDriver.TryActuallyStartNextToil: System.NullReferenceException: Object reference not set to an instance of an object
[Ref CF511973]
at Despicable.HarmonyPatch_Memory.Postfix (RimWorld.Thought_Memory newThought, Verse.Pawn otherPawn) [0x0019b] in <dc46024ee1cf438c83b9592711d79d63>:0
at RimWorld.MemoryThoughtHandler.TryGainMemory (RimWorld.Thought_Memory newThought, Verse.Pawn otherPawn) [0x00299] in <cb53cd4422904947932d33f561ad8d15>:0
- TRANSPILER VFEEmpire.Mod: IEnumerable`1 VFEEmpire.HarmonyPatches.Patch_ThoughtStacking:Transpiler(IEnumerable`1 instructions, MethodBase original)
- POSTFIX OskarPotocki.VEF: Void VEF.Pawns.VanillaExpandedFramework_MemoryThoughtHandler_TryGainMemory_Patch:Postfix(MemoryThoughtHandler __instance, Thought_Memory& newThought, Pawn otherPawn)
- POSTFIX vanillaexpanded.achievements: Void AchievementsExpanded.AchievementHarmony:ThoughtInitialized(Thought_Memory newThought)
- POSTFIX vanillaexpanded.aspirations: Void VAspirE.SatisfactionPatches:CheckGeneral(Pawn ___pawn)
- POSTFIX com.DCSzar.Despicable: Void Despicable.HarmonyPatch_Memory:Postfix(Thought_Memory newThought, Pawn otherPawn)
- POSTFIX com.VEHighmate: Void VanillaRacesExpandedHighmate.VanillaRacesExpandedHighmate_MemoryThoughtHandler_TryGainMemory_Patch:HandlePawnMemories(Thought_Memory newThought, Pawn otherPawn, MemoryThoughtHandler __instance)
- POSTFIX OskarPotocki.VanillaSocialInteractionsExpanded: Void VanillaSocialInteractionsExpanded.TryGainMemory_Patch:Postfix(MemoryThoughtHandler __instance, Thought_Memory newThought, Pawn otherPawn)
at RimWorld.MemoryThoughtHandler.TryGainMemory (RimWorld.ThoughtDef def, Verse.Pawn otherPawn, RimWorld.Precept sourcePrecept) [0x0002d] in <cb53cd4422904947932d33f561ad8d15>:0
at Verse.Pawn_HealthTracker.PreApplyDamage (Verse.DamageInfo dinfo, System.Boolean& absorbed) [0x002b3] in <cb53cd4422904947932d33f561ad8d15>:0
at Verse.Pawn.PreApplyDamage (Verse.DamageInfo& dinfo, System.Boolean& absorbed) [0x00065] in <cb53cd4422904947932d33f561ad8d15>:0
- POSTFIX VREHussars.Mod: Void VREHussars.Pawn_PreApplyDamage_Patch:Postfix(Pawn __instance, DamageInfo& dinfo)
at Verse.Thing.TakeDamage (Verse.DamageInfo dinfo) [0x00131] in <cb53cd4422904947932d33f561ad8d15>:0
- PREFIX OskarPotocki.VEF: Void VEF.AnimalBehaviours.Patch_TakeDamage:Prefix(Thing __instance, DamageInfo dinfo)
- PREFIX ReBuildDoorsAndCornersMod: Void ReBuildDoorsAndCorners.Thing_TakeDamage_Patch:Prefix(Thing __instance, DamageInfo& dinfo)
- PREFIX rimworld.neptimus7.storytellerenhanced: Void StorytellerEnhanced.Thing_TakeDamage:Prefix(Thing __instance, DamageInfo& dinfo)
- PREFIX VFETribalsMod: Void VFETribals.Thing_TakeDamage_Patch:Prefix(Thing __instance, DamageInfo& dinfo)
- PREFIX Syrus.YayosCombatAddon: Void yayoCombat.HarmonyPatches.Thing_TakeDamage:Prefix(DamageInfo& dinfo)
- POSTFIX OskarPotocki.VEF: Void VEF.Weapons.VanillaExpandedFramework_Thing_TakeDamage_Patch:Postfix(Thing __instance, DamageInfo dinfo)
- POSTFIX com.CaesarV6.DamageMotes.Patch: Void DamageMotes.DamageMotes_Patch:Postfix(DamageInfo dinfo, Thing __instance, DamageResult __result)
at RimWorld.ExecutionUtility.ExecutionInt (Verse.Pawn executioner, Verse.Pawn victim, System.Boolean huntingExecution, System.Int32 bloodPerWeight, System.Boolean spawnBlood) [0x000ed] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.ExecutionUtility.DoExecutionByCut (Verse.Pawn executioner, Verse.Pawn victim, System.Int32 bloodPerWeight, System.Boolean spawnBlood) [0x00000] in <cb53cd4422904947932d33f561ad8d15>:0
at RimWorld.JobDriver_Sacrifice+<>c__DisplayClass5_0.<MakeNewToils>b__0 () [0x00034] in <cb53cd4422904947932d33f561ad8d15>:0
at Verse.AI.JobDriver.TryActuallyStartNextToil () [0x00208] in <cb53cd4422904947932d33f561ad8d15>:0
- TRANSPILER net.pardeike.rimworld.lib.harmony: IEnumerable`1 VisualExceptions.ExceptionsAndActivatorHandler:Transpiler(IEnumerable`1 instructions, MethodBase original)



Additionally, i tried to test the mod by ordering two pawn to do lovin manually, they were infinitely standing, but no specific animation was playing, one pawn was said to be "getting lovin from X", other "givin lovin to Y", and they were stuck luck this until i drafted and undrafted them. Here's the error potentially related to that.

Exception in Verse.AI.Toil.Cleanup: System.NullReferenceException: Object reference not set to an instance of an object
[Ref BFF4BF52]
at Despicable.CompExtendedAnimator.Reset () [0x0004d] in <dc46024ee1cf438c83b9592711d79d63>:0
at Despicable.AnimUtil.ResetAnimatorsForGroup (System.Collections.Generic.List`1[T] pawns) [0x0001b] in <dc46024ee1cf438c83b9592711d79d63>:0
at Despicable.JobDriver_LovinBase.<LovinToil>b__13_2 () [0x0001e] in <dc46024ee1cf438c83b9592711d79d63>:0
at Verse.AI.Toil.Cleanup (System.Int32 myIndex, Verse.AI.JobDriver jobDriver) [0x0001f] in <cb53cd4422904947932d33f561ad8d15>:0
- TRANSPILER net.pardeike.rimworld.lib.harmony: IEnumerable`1 VisualExceptions.ExceptionsAndActivatorHandler:Transpiler(IEnumerable`1 instructions, MethodBase original)

It also appears that pawns do not engage in lovin normally with this mod on.

I'm sorry i'm bugging you when my modlist is quite big and it's a pain to troubleshoot, but also this mod is the only one that seems to be conflicting so bad that these kinds of bugs appear.

Full log: https://gist.github.com/HugsLibRecordKeeper/18f770945f771daf583fbc2b91d67fc8

Nah, I don't get super pissy about reports. I'll take another look at it, probably just forgot to use a null check. Thanks for the report

@Dealer Mangan Also do you have intimacy installed? And are you talking about vanilla in-bed lovin' or just lovin' in general? Asking for debugging reasons

Yes, i use Intimacy mod. I suppose it replaces vanilla lovin'?

I haven't read enough of Turkler's code to know for sure, but I'd assume so since it removes the need for a bed to be involved and has precepts related to lovin'.

My mod doesn't affect lovin' chances at all, only tries to mimic them when no bed is involved. Also, I turned off my checks completely in favor of intimacy's if it's installed.