Store Page
RimWorld
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

RimWorld

Store Page
RimWorld >  Workshop > Dizzy Ioeuy's Workshop > [Dizzy] Poor Sight Matters More > Discussions
[Dizzy] Poor Sight Matters More
Description Discussions1 Comments28 Change Notes
moo 25 Jun @ 10:19pm
1.6 patch failing
[[Dizzy] Poor Sight Matters More] Patch operation Verse.PatchOperationReplace(Defs/StatDef[defName="MoveSpeed"]/parts/li[1]/factorFromGlowCurve/points/li[1]) failed
file: Z:\SteamLibrary\steamapps\workshop\content\294100\3392675400\Patches\SightAffectsSpeed.xml
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition:Verse.Log.Error_Patch2 (string)
Verse.PatchOperation:Complete (string)
Verse.LoadedModManager:ClearCachedPatches ()
Verse.LoadedModManager:LoadAllActiveMods (bool)
Verse.PlayDataLoader:DoPlayLoad ()
Verse.PlayDataLoader:LoadAllPlayData (bool)
Verse.Root/<>c:<Start>b__10_1 ()
Verse.LongEventHandler:RunEventFromAnotherThread (System.Action)
Verse.LongEventHandler/<>c:<UpdateCurrentAsynchronousEvent>b__28_0 ()
System.Threading.ThreadHelper:ThreadStart_Context (object)
System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object)
System.Threading.ThreadHelper:ThreadStart ()

Mod list at https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=3507289931
< >
Showing 1-8 of 8 comments
moo 29 Jun @ 3:10pm 
XML extensions is out - so here's more context:

[[Dizzy] Poor Sight Matters More - Start of stack trace]
Verse.PatchOperationReplace(xpath="Defs/StatDef[defName="MoveSpeed"]/parts/li[1]/factorFromGlowCurve/points/li[1]"): Failed to find a node with the given xpath
[End of stack trace]
The top operation is the one that failed, the ones below it are the parents
Source file: Z:\SteamLibrary\steamapps\workshop\content\294100\3392675400\Patches\SightAffectsSpeed.xml
#1
Dizzy Ioeuy  [developer] 29 Jun @ 3:41pm 
There are 472 mods in that list... I am not about to dig through it and then find the exact incompatibility. Poor Sight Matters works without any errors in vanilla v1.6. You need to troubleshoots your mods.

Having said that, I have a guess for you that it is this code, from the mod Stats Matter (continued):

<Operation Class="XmlExtensions.ApplyPatch">
<patchName>MoodMatters_MoodPatch</patchName>
<arguments>
<li>movespeed</li>
<li>Move speed</li>
<li>MoveSpeed</li>
<li>90</li>
<li>110</li>
</arguments>
</Operation>

That reads as a brutal table change.

But I could be wrong. In fact I likely am... 471 more mods to go.

XML extensions is a ♥♥♥♥♥♥♥ mess and once that mod is in place, and another mod depends on it to operate, I'm not likely to be of any further help.

Good luck.
#2
moo 29 Jun @ 3:43pm 
Ok, I'll see if the mod author can check that

Thanks!
#3
velcroboy333 30 Jun @ 12:40pm 
Stats Matter maintainer here. That patch doesn't come from my mod it does not use XML Extensions. I tested both these mods together and they work as intended just fine. Must be another mod.
#4
velcroboy333 30 Jun @ 12:43pm 
Oh, I see where you got that from now. I forgot I had some experimental stuff I was testing for fun. That file is only a .txt file though and should not have any effect.
#5
moo 4 Jul @ 3:46pm 
Found it, Rimbody - Stat Module
#6
Dizzy Ioeuy  [developer] 5 Jul @ 3:56pm 
Yep, he adds a <li> definer and changes the entry:

<Operation Class="PatchOperationAdd">
<xpath>*/StatDef[defName = "MoveSpeed"]/parts</xpath>
<order>Prepend</order>
<value>
<li Class="Maux36.Rimbody_StatModule.PhysiqueFatHinderancePart"/>
</value>
</Operation>
#7
Maux 7 Jul @ 4:33pm 
Rimbody developer here.

It seems your patch relies on list ordering, but isn't that bound for incompatibilities like this? You'll have conflict with any mod that prepends statparts on move speed. And it being a stat, I can see many mods would want to add to parts.

I believe the better compatibility would be for this mod to implement targeted patch by doing something like li[Class="StatPart_Glow"] instead of li[1]?
Last edited by Maux; 7 Jul @ 4:33pm
#8
< >
Showing 1-8 of 8 comments
Per page: 1530 50