Store Page
RimWorld
All Discussions Screenshots Artwork Broadcasts Videos Workshop News Guides Reviews

RimWorld

Store Page
RimWorld >  Workshop > Matsay's Workshop > Forsaken Faction For Alpha Genes > Discussions
Forsaken Faction For Alpha Genes
Description Discussions1 Comments18 Change Notes
 This topic has been pinned, so it's probably important
Matsay  [developer] 18 Nov, 2024 @ 1:19am
BUG REPORTS
You know the drill. Report bugs here, try to join a log as it makes troubleshooting much more easier, yadda yadda.
< >
Showing 1-2 of 2 comments
Dibolic 6 Sep @ 2:15pm 
Hello, I am not sure if the issue I encounter is on you side or on the other mod side.
I use Simple Improve https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=3538863870 that adds an improve job for building, like a basic wooden chair. When I click to order a pawn to improve the building I got the following error

Exception in WorkGiverOptionProvider_WorkGivers.GetWorkGiversOptionsFor for WorkGiver_Improve: System.NullReferenceException: Object reference not set to an instance of an object [Ref 94621A96] at ForsakenFaction.FOF_CanConstruct_Postfix.Postfix (System.Boolean __result, Verse.Thing t, Verse.Pawn p, Verse.JobDef jobForReservation) [0x00007] in <6ac944cfd9264e2db54159419bbf016e>:0 at RimWorld.GenConstruct.CanConstruct (Verse.Thing t, Verse.Pawn p, System.Boolean checkSkills, System.Boolean forced, Verse.JobDef jobForReservation) [0x00520] in <24d25868955f4df08b02c73b55f389fe>:0

In Simple Improve side, it seems the caller code is, and check for pawn skill level depending of targeted quality:
if (!GenConstruct.CanConstruct(thing, pawn, true, forced)) return null;

I got a look in the included source code for both mods but I am unable to tell where is the issue

I can reproduce the issue by loading a dev test with only the involved mods: base game and official DLCs, your mod and its dependencies and Simple Improve (requiring only Harmony); and trying to improve quality of a wooden stool.

Can you have a look?
#1
Dibolic 4 Oct @ 12:30am 
I eventually got my hands into the code and find a solution.

t.def.entityDefToBuild
may not exist in some situations, like with Simple Improve action.
Adding null safe navigation of Thing properties fix the NRE from your mod.

ForsakenKnowledgeExtension extension = t?.def?.entityDefToBuild?.GetModExtension<ForsakenKnowledgeExtension>();
#2
< >
Showing 1-2 of 2 comments
Per page: 1530 50