Butikssida
Crusader Kings III
Alla Diskussioner Skärmbilder Konst Sändningar Filmer Workshop Nyheter Guider Recensioner

Crusader Kings III

Butikssida
Crusader Kings III >  Workshop > Kazarions workshop > Unofficial Patch > Diskussioner
Unofficial Patch
Beskrivning Diskussioner11 Kommentarer951 Ändringar
pharaox  [utvecklare] 12 okt, 2024 @ 2:15
Fix suggestions
I often come across various vanilla issues while playing or working on mods. I usually report them to Paradox (if they are not already reported), and then I sometimes fix them in a local ad-hoc mod for my own use (https://github.com/pharaox/ck3_fixes). I would be happy if you consider adding them to Unofficial Patch, so I am staring a dedicated discussion about such fix suggestions to avoid posting them in the main discussion.

It would be even easier for me (and probably for you as well) if the mod had a GitHub repo and I could open these fixes as PRs, but I respect your decision if you don't want this for some reason.

Many thanks for the fixes you already included!
< >
Visar 1-15 av 31 kommentarer
pharaox  [utvecklare] 12 okt, 2024 @ 2:24 
Here is a new batch of vanilla issues and fixes:

"Abduct Foe" scheme issues: fixes in https://github.com/pharaox/ck3_fixes/commit/33a25f4289e464f9096c0fe5dc0f8fc8421ca4f6.
* https://forum.paradoxplaza.com/forum/threads/sucessful-abduct-foe-contract-leaves-captive-in-your-own-prison-afterwards-instead-of-transfering-him-her-to-the-contractor.1706194/
* https://forum.paradoxplaza.com/forum/threads/balanced-option-in-hostile-acquisitions-is-not-really-balanced.1709183/

"Spouse Material" characters sometimes too old: fix in https://github.com/pharaox/ck3_fixes/commit/9c3928b03b82265e217511c1478d0301a3be5776.
* https://forum.paradoxplaza.com/forum/threads/spouse-material-characters-are-sometimes-way-too-old.1709184/

False "Fugitive" warning: fix in https://github.com/pharaox/ck3_fixes/commit/f53bf0ff8436fd1ccc63e8fd22aa1aa79b5649b6, see lines marked as "FIX"
* https://forum.paradoxplaza.com/forum/threads/false-fugitive-warning-if-a-landless-adventurer-is-considered-criminal-by-a-ruler.1709191/

Correct validity trigger for "Master of Horse" court position: fix in https://github.com/pharaox/ck3_fixes/commit/a17d263db7f2e892c749283ab1e889cb8e7b403f, see line marked as "FIX"
#1
pharaox  [utvecklare] 12 okt, 2024 @ 8:06 
And another one: https://forum.paradoxplaza.com/forum/threads/traveling-as-a-landless-adventurer-removes-all-army-commanders-and-prevents-them-from-being-reassigned.1709203/

The fix is in https://github.com/pharaox/ck3_fixes/commit/0b22b877defeebf638610058ea34c6af99728817, see lines marked as "FIX".
#2
wilki24 12 okt, 2024 @ 20:33 
Hey, thanks for sharing these! I merged your fixes into my own local copy, was really nice having less log spam!
#3
WheelOfMisery 13 okt, 2024 @ 13:51 
The first post has a broken link to github
#4
pharaox  [utvecklare] 14 okt, 2024 @ 9:28 
@WheelOfMisery Which one? They all open fine for me.
#5
WheelOfMisery 15 okt, 2024 @ 12:23 
First, when clicked, it opens this:
https://(https/github.com/pharaox/ck3_fixes)
#6
pharaox  [utvecklare] 15 okt, 2024 @ 14:05 
@WheelOfMisery, it just opens fine for me, could it be a browser issue on your side. In any case, I don't see what I could do about it.
#7
pharaox  [utvecklare] 1 nov, 2024 @ 9:21 
Here is another one, a pretty major one from my perspective: https://forum.paradoxplaza.com/forum/threads/ai-landless-adventurers-are-not-visiting-settlements-if-you-switch-to-any-of-them-you-cant-as-well.1712826/. The fix is in https://github.com/pharaox/ck3_fixes/commit/2673e991e2b7195594ecc26b603bf546feeba63d.
#8
pharaox  [utvecklare] 6 nov, 2024 @ 10:11 
And another major one: https://forum.paradoxplaza.com/forum/threads/scout-for-talent-travel-option-does-nothing.1709563/.
The fix is in https://github.com/pharaox/ck3_fixes/commit/88a662c2409c6f9735d3f83dc32b1913aba71134, see the single line marked with "FIX".
#9
shautora 8 dec, 2024 @ 8:22 
So how exactly does this work? Do we need to set up a new personal Git repository for fixes and then we share the fixes here by pasting links? Or is there some way we can get authorized to submit PR’s to the actual mod? I just found a bunch of teeny errors in one of the event files I’m working with…
#10
pharaox  [utvecklare] 9 dec, 2024 @ 9:27 
@shautora Please contact @Kazarion for access to the mod's GitHub repo. There is one, but it's private for now. I already have access and so I stopped adding suggestions here and started opening PRs instead.
#11
shautora 9 dec, 2024 @ 12:58 
Thanks!
#12
LVLVbNH 13 dec, 2024 @ 11:58 
Heavily suspect that event `faith_creation.0003` in events\religion_events\faith_creation_events.txt have wrong assigned trigger
is_ai = no
since event body have defined logic for both scenarios - if it apply to player and if it apply to ai
Senast ändrad av LVLVbNH; 13 dec, 2024 @ 16:54
#13
pharaox  [utvecklare] 14 dec, 2024 @ 0:35 
@LVLVbNH You may be right, but I think this event will likely never be fired with AI as root, since AI rulers can't create new faiths. How did you notice this, did you see any strange ingame effects caused by it?
#14
LVLVbNH 14 dec, 2024 @ 1:58 
Ursprungligen skrivet av pharaox:
since AI rulers can't create new faiths.
according to religion_on_actions.txt this event also should fire on religion reformation for unreformed which AI is allowed
Ursprungligen skrivet av pharaox:
How did you notice this
After analyzing warnings in error.log after apply `Morven's Mods 1.14 Compatch` i notice old code that look like fix for thix bug but in weired way
Ursprungligen skrivet av pharaox:
did you see any strange ingame effects caused by it?
Not yet because im never see pagan reform their religions)
Senast ändrad av LVLVbNH; 14 dec, 2024 @ 1:58
#15
< >
Visar 1-15 av 31 kommentarer
Per sida: 1530 50