Crusader Kings III

Crusader Kings III

Unofficial Patch
pharaox  [desarrollador] 12 OCT 2024 a las 2:15
Fix suggestions
I often come across various vanilla issues while playing or working on mods. I usually report them to Paradox (if they are not already reported), and then I sometimes fix them in a local ad-hoc mod for my own use (https://github.com/pharaox/ck3_fixes). I would be happy if you consider adding them to Unofficial Patch, so I am staring a dedicated discussion about such fix suggestions to avoid posting them in the main discussion.

It would be even easier for me (and probably for you as well) if the mod had a GitHub repo and I could open these fixes as PRs, but I respect your decision if you don't want this for some reason.

Many thanks for the fixes you already included!
< >
Mostrando 1-15 de 31 comentarios
wilki24 12 OCT 2024 a las 20:33 
Hey, thanks for sharing these! I merged your fixes into my own local copy, was really nice having less log spam!
WheelOfMisery 13 OCT 2024 a las 13:51 
The first post has a broken link to github
pharaox  [desarrollador] 14 OCT 2024 a las 9:28 
@WheelOfMisery Which one? They all open fine for me.
WheelOfMisery 15 OCT 2024 a las 12:23 
First, when clicked, it opens this:
https://(https/github.com/pharaox/ck3_fixes)
pharaox  [desarrollador] 15 OCT 2024 a las 14:05 
@WheelOfMisery, it just opens fine for me, could it be a browser issue on your side. In any case, I don't see what I could do about it.
shautora 8 DIC 2024 a las 8:22 
So how exactly does this work? Do we need to set up a new personal Git repository for fixes and then we share the fixes here by pasting links? Or is there some way we can get authorized to submit PR’s to the actual mod? I just found a bunch of teeny errors in one of the event files I’m working with…
pharaox  [desarrollador] 9 DIC 2024 a las 9:27 
@shautora Please contact @Kazarion for access to the mod's GitHub repo. There is one, but it's private for now. I already have access and so I stopped adding suggestions here and started opening PRs instead.
shautora 9 DIC 2024 a las 12:58 
Thanks!
LVLVbNH 13 DIC 2024 a las 11:58 
Heavily suspect that event `faith_creation.0003` in events\religion_events\faith_creation_events.txt have wrong assigned trigger
is_ai = no
since event body have defined logic for both scenarios - if it apply to player and if it apply to ai
Última edición por LVLVbNH; 13 DIC 2024 a las 16:54
pharaox  [desarrollador] 14 DIC 2024 a las 0:35 
@LVLVbNH You may be right, but I think this event will likely never be fired with AI as root, since AI rulers can't create new faiths. How did you notice this, did you see any strange ingame effects caused by it?
LVLVbNH 14 DIC 2024 a las 1:58 
Publicado originalmente por pharaox:
since AI rulers can't create new faiths.
according to religion_on_actions.txt this event also should fire on religion reformation for unreformed which AI is allowed
Publicado originalmente por pharaox:
How did you notice this
After analyzing warnings in error.log after apply `Morven's Mods 1.14 Compatch` i notice old code that look like fix for thix bug but in weired way
Publicado originalmente por pharaox:
did you see any strange ingame effects caused by it?
Not yet because im never see pagan reform their religions)
Última edición por LVLVbNH; 14 DIC 2024 a las 1:58
< >
Mostrando 1-15 de 31 comentarios
Por página: 1530 50