✅ Update fix: Fallback to Default AI toggle now properly updates when loading presets

COMPATIBILITY UPDATE: NPCs now automatically skip to next CustomAI instruction when targeted spells are unavailable, added to support NPCSpellFix Nightly's new spell charge system.

@python

https://imgur.com/a/jQRMRp0

There is an image that shows after I loaded in your rule, my Melilith successfully cast Miasma on the enemy, then death arrow. A video doesn't help me (and I would rather play Elin than troubleshoot tbh). It might be a mod load order issue, or something beyond my control (and without logs, it's really nothing I can do). Also your imported example caused no lag on my side with my PC, and I have >150 mods.

@grueshanker

Thanks for response. Thats what I thought, top down, first rules valid will be executed.

I have added fallback to vanilla, and a very simple rules: https://pastebin.com/JiPyi9yZ

Still fail to execute. Let me figure out a way to screen recording. Also the lag only happen when first rule fail. I have tried to load area with very small number of enemy, no summoning.

@Spiegel

AWESOME,
thanks for testing and confirming!! appreciate it

@grueshanker
I've confirmed the issue has been resolved!
All the MODs you create are so interesting! I'm rooting for you! Thank you!

@python

I also think you misunderstand how the mod works. I didn't change the behavior from the original mod in the regard you are talking, this is what description says:
* Each instruction in the list is checked from top to bottom, and the first one with a valid condition is executed.

And that's what your rules are doing. The lag, may be many AI on screen but may want to test original too for that.

If you want something more dynamic, try this: https://pastebin.com/spr11zCd
That reads: If Enemy HP <= 100% AND Enemy Distance < 3, Attack (Melee) Target.
If NPC cannot do that, it then tries to cast hero on player. if it cannot do that, it moves to the player. If you do not enable vanilla fallback, sometimes they will just stand. That is base mod behavior.

@python:
>> What is the difference between target vs enemy when npc cast attack spell?

Can I see specific rule? Question is not specific enough. I have export feature, please use it and use pastebin

@python I don't intend to debug performance issue, but fyi I can run twice the rules with no lag on my PC. Just remember using any mod comes with risk of performance, especially with many AI on screen.

The original code is open source, you're free to take a look and I can decompile mine to check or fix anything :)

Update @Spiegel, I fixed a InvalidCastException

Something sure wrong with how the mod evaluate invalid conditions.

I did very simple rules:
1. Enemy status != Miasma then cast Miasma at target
2. Enemy HP <= 100% cast death arrow at target

This will do rule 1, then Melith npc stay afk, and fps/screen lag. If I swap rules 1 and 2, it works, since now the condition Enemy HP <= 100% always true.

Which means, the mod has issue when the the rules move from True to False

I'm not sure if this is the right way to do it, but I tried modifying only the username part and pasting everything.
If there's a better way, I'd appreciate it if you could let me know.

https://pastebin.com/NUDhYH6A

What is the difference between target vs enemy when npc cast attack spell?

Sometimes this mod cause spike lag, especially with multiple conditions ( I got about 5 rules for 2 party members)

Also, I am not sure if I set conditions wrong. But anything above auto range attack will make it not range attack:

1. Farris will cast hero if player status is not heroic mood at "target"
2. Will attack "any enemy" if enemy hp <= 100%

1 will trigger then Farris afk. If I delete 1, then 2. will work normally

@Spiegel

can you post Player.log? The reasons you've given cannot be replicated by me.

thank you for catching this! I appreciate the tests : )

I will look into this

self status != EnchantedWeapon 混沌の唄(Chaos Intonation)　target

I've specified actions in the order listed above, but I'm getting the error [invalidCastException: Specified cast is not valid.].
Possible causes I suspect are:
① My language settings are in Japanese
② The character in question acquired abilities through a special method involving kk with my sister
③ Elin is the stable version
④ Influence from numerous other MODs
I believe one of these is the cause. Your MOD is truly excellent, so I'd like to resolve this issue.

Translated with DeepL

thanks for the kind words! please test and feel free to give any feedback.

You're the GOAT!
Much love. No homo.

:))) still grueshanker - who remake all combat mod pro vip. Thanks grueshanker