RimWorld

RimWorld

Categorized Cleaning - Combo
21 Comments
ましろ 23 Aug @ 11:41pm 
Exception while rebuilding dirty regions: System.NullReferenceException: Object reference not set to an instance of an object [Ref 2109475E] at PeteTimesSix.CategorizedCleaning.HarmonyPatches.Room_Notify_RoomShapeChanged_Patches.Room_Notify_RoomShapeChanged_Prefix (Verse.Room __instance) [0x00000] in C:\RimworldProjects\CategorizedCleaning\CategorizedCleaningCombo\Source\HarmonyPatches\Room_Patches.cs:22 at Verse.Room.Notify_RoomShapeChanged () [0x00000] in <cb53cd4422904947932d33f561ad8d15>:0 - PREFIX PeteTimesSix.CategorizedCleaning: Void PeteTimesSix.CategorizedCleaning.HarmonyPatches.Room_Notify_RoomShapeChanged_Patches:Room_Notify_RoomShapeChanged_Prefix(Room __instance)
PhoenixLabella 24 Jul @ 9:26am 
Yep, that was the problem. It is working fine now.
Thx a lot. :greedyHeart:
PhoenixLabella 17 Jul @ 9:37pm 
I will try, and thanks for the heads-up. :greedyHeart:
PeteTimesSix  [author] 16 Jul @ 2:45am 
@PhoenixLabella word on the discord is there's broken versions of Pick Up and Haul about that cause issues like that. Try removing it if you have it, see if that helps?
PhoenixLabella 15 Jul @ 1:29pm 
I ran into a problem where units stay idle while there is dirt and don't perform any other tasks. When I set the Clean priority to 1, they do the cleaning and other tasks; when I lower the priority, they go back to being idle as long as there's dirt.
My mod list is a bit long (~200), so I wouldn't know which one is causing the conflict, but unfortunately I had to remove this mod from the list.
Naturtok 15 Jul @ 1:18am 
Makes sense! Just wanted to make sure I wasn't missing anything since they seemed similar. Def would be interested in seeing which process ends up being more performant. Either way, I like the way yours is handled more from a ux side of things
PeteTimesSix  [author] 13 Jul @ 12:50am 
@Naturtok
I guess I did miss some cleaning mods when checking the workshop after all :]
Looking at the source, it patches GetPriority on the vanilla CleanFilth WorkGiver, whereas my mod works by pre-filtering filth into categories and adding two new work givers.
The end result ends up being pretty similar, though Cleanie seems to be more configurable. Someone'd have to profile the two mods to know for sure which has a bigger performance impact.
Naturtok 12 Jul @ 11:21pm 
Is there any mechanical difference between this and Cleanie? Cleanie seems to do the same thing, but w/ cleanliness threshold sliders for each room instead of categories, but I have zero clue how mods work under the hood
Hightech 12 Jul @ 8:56pm 
will give it a try :steamthumbsup:
If you have an issue of endless looping of cleaning > butchering, it's an issue with Common Sense + Categorized Cleaning. Both have been patched it looks like, just unsubscribe and resubscribe to the mods to redownload. Can confirm it works afterwards.

(Also shared by Author below, posting that I confirmed it works after updating both)
allbad 12 Jul @ 8:00am 
@petetimesix thank you for the education, I did not know this about workshop items
PeteTimesSix  [author] 12 Jul @ 6:17am 
@Dartvard @Veganismo
Compat with Common Sense should be in now. Make sure to also get the needed update to Common Sense.
Dartvadr 12 Jul @ 5:43am 
Im having the same issue. it might be related to Common sense mod too
Veganismo 11 Jul @ 3:47pm 
When it's activated, the colonists bug out. In the kitchen, they glitch and can't butcher or cook, but they also don't clean to make it possible, causing a loop.
PeteTimesSix  [author] 11 Jul @ 1:49pm 
@Skuffet I think I did a pretty good job optimizing things. Though its hard to comprehensively check that kind of thing without a full playthrough of a long-running colony.
Skuffet 11 Jul @ 12:56pm 
Lovely mod, is there any noticeable effect on performance compared to vanilla?
PeteTimesSix  [author] 11 Jul @ 12:38pm 
@allbad
Steam limits the amount of stars for newer workshop items / items with less subscribers than some unseen threshold. The actual ratings are all positive so far :]
allbad 11 Jul @ 12:29pm 
genuine question: Why 4 out of 5 stars? I wish people would leave a comment on new mods if they don't feel like 5 stars. I'm going to try this anyway because author's description solves one of my long standing pain-points
Pheace 11 Jul @ 11:08am 
Sounds amazing, especially with the config to pick which rooms are sterile, thanks!
LoggerC4 10 Jul @ 6:05am 
Wonderful! I like how out-of-the-box this is
Futstub 10 Jul @ 5:05am 
Neat.