Thank you mod maker for your response and your attempts to fix the issue, your work is most appreciated.

@Valentine
I have rewritten the patch into a Transpiler because it doesn't seem to play well with performance as a Postfix. It still has the added safeguards because I really don't want to bork peoples games with potential unhandled exceptions - even though there have never been reports, can never be too careful with the weather system.

@Valentine
Ah, very true. That paragraph was from back when all this mod did was change commonalities. Offsets were a later addition. I will be changing the description and also trying to fix the performance hit you have pointed out as I can reproduce it.

It seems like the alert for colonist clothing is calling the temperature on the current map every single UI draw, causing the slowdown. I used very "safe" approaches to the patches (try-catching), which incurs a minor performance penalty for the sake of preventing possible issues from breaking the game.

Dear mod maker. The description of your mod claims it has no performance impact and uses no Harmony patches yet in Dubs' Performance Analyzer this is my biggest draining Harmony patch causing a constant minimum performance hit of 0.100ms but with a max spike of up to 50ms from "WeatherControl.Patches.Patch_Temperature:AddSeasonOffsetFromTemperatureControl"

Granted this is in a full modlist and from other's testing it does not cause almost any performance hit if it's just by itself but it clearly doesn't play nice with other mods and it goes against the claims of the description that this doesn't use Harmony patches which is false and misleading.

Kind regards from yours truly.

oh thank god for this mod.
i hate the winter "mandatory starvation arc" every year, and i hate that setting the heat setting up by 1 tick to turn off winter makes the map 150 degrees celcius all year long & your colonists drop dead just from opening the front door with no in-between

You did an awesome work on UI, and it's a great mod idea. Shame on me to discover this jewel right now. Thanks for the hard work !

Could you add an option for temperature control so that it sets the temperature to a specified value rather than combining it with the existing local temperature? I have a target temperature in mind, but it’s very difficult to calculate it when it’s added to the current temperature.
(I apologize if my English is rude or incorrect. I’m using a translator.)

@infinite-jewery
Kinda. Pocket maps have their own weather def, so you can define their weather. I know for certain that the Obelisk Labyrinth uses "Labyrinth" and the insect and fleshbeast hives use "Undercave".

Does this work on pocket maps?

So does this mean i can make a permanent summer into a summer and spring or is that smth else

@TheNamelessOne
Sandstorms can happen as an incident or as a natural weather. You may be experiencing sandstorm incidents if your map does not naturally have sandstorm as a weather (proximity to world tiles that do have weather).

I kinda don't remember if there is an option to turn off sandstorm incidents, but in the absolute worst case you can use the mod Cherry Picker to disable the IncidentDef for sandstorms. I may look into a nicer way of achieving that in the future if it does not exist yet.

In the mod options under duration range, sandstorm is set 3 hours - 1 day by default...but it seems they always last 3 days or more! Is this suppose to happen?

@NightmareCorporation

Thanks for the explanation :)

@Wally Winker ;)
As "offsets" they modify the base games weather. So if you set an offset of +10°C, and the current map would normally have a temperature of 18°C, then the actual temperature your pawns experience with this mod will be 28°C.

Can anyone explain this aspect of temperature control to me: Are temperature offsets set within the mod settings summed with the vanilla temperature fluctuations or do they override them?

yessss thank you i been trying to find a way to change my tile's temperature range without having to restart on a new tile

Thank you so much :)

@Taemaly
Apologies, an update in NightmareCore led to that. I just pushed updates to both this mod and NightmareCore, so when steam updates those two mods for you it should be gone.

Thanks for the report!

Getting errors at the start with no other mods : https://gist.github.com/HugsLibRecordKeeper/60aea8c3e5beef2bd8bcc966514df032

@Skyshadow
I skipped over the other question, sorry - the offsets are raw additions, so if you set it to +20°F where default would be 0-60 it would now be 20-80.

@Skyshadow
Ah damn, I assume it says 32F at the default position? I'll fix that right away.

Just to clarify, when it says +32 F I'm assuming that is just a translation error moving from C to F and not that it actually adds 32 degrees. Is that correct? And any up or down on the sliders adds or subtracts by that much?

If a biome has a temperature range of 0-60F normally then if I raise summer by +20 F does that mean the new range will be 0-80F or should I be setting the slider for the temps I actually want to see?

@Zedd
Oh yea! That was the problem, I forgot to specify that WeatherControl must be loaded *after* the framework. I have pushed a fix, there is nothing wrong with either mod, it was just the order they are in :D

Oh ya apologies when I uploaded that log I think I forgot to put nightmare first. But I'm quite sure the first time I had the problem both nightmare and weather were near the top, with nightmare first, but maybe that was my problem the first time. I just tested it out now and when nightmare is below weather, it is not flagged red in my mod order and clicking auto-sort doesn't fix it.

@Zedd
To clarify: This behavior happens when you move both NightmareCore and WeatherControl to the top this happens?

I want to make sure you have NightmareCore above WeatherControl, but that should also be validated by the game.

You uploaded a local log, which does show the error (hence why I want to make sure you load my mods in the right order, because having them in the wrong order usually causes that type of error) - but the log does not include the mod load order, the mod I linked previously includes it though, so I would recommend using that.

To clarify: log is when it's at the top, which includes the one error (I recall it being more than one error previously). At the bottom of the order there's no error.

k I'm a noob so hopefully I did this correctly. I was wrong earlier when I said I still got the error when it was at the bottom of the list...when I move it it's fine. So I moved it to the top and copied the log. If it asks for a pw it's rimworld. https://pastebin.com/hpXyphUj

@Zedd
I think I have had reports of the mod settings not showing before, but never with a log to troubleshoot. If you can provide that to me I can look into it, as I have been unable to reproduce this issue myself.

https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=287341540 will allow you to press CTRL + F12 to send a log to me, or copy your local log from this path "C:\Users\<USER>\AppData\LocalLow\Ludeon Studios\RimWorld by Ludeon Studios\Player.log" into a web service like https://pastebin.com/

FYI just to chime in on the mod order discussion...I had it and nightmare up near the top, nothing showed up in mod option (but the research option for the weather station was there). I moved it to the bottom and now I see the mod options. I do still have maybe 5-10 red errors on load but it looks like they're related to the weather station? In any case, moving to the bottom worked for me.

@no profile
I have added more safety checks that should prevent this behavior from happening again.

Due to how steam mods work, you may need to unsubscribe from NightmareCore and WeatherControl, then subscribe again to download the latest version.

Thank you for your quick reply. English relies on machine translation, so it doesn't work very well.
To be honest, starting with Winter... there are many interesting works, but there are some unstable movements.

@no profile
The author of that mod breaks the commonality logic by providing a broken reference. It seems they are aware of the issue? I will suggest a fix to them and tighten up edge cases where broken weather commonalities like that won't break this mod.

If https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=2793410549 was present, the option could not be opened and the game could not continue.

It might just be me, but I'll leave it there.

@Ambit
The rainfall stat on a tile and that fires mod does indeed influence the weathers determined by this mod. WeatherControl only modifies the "base commonality" of weather, which is then flowing through some tile-relative logic.

- There is a section that massively increases rainy weather likelihood if a large fire is present
- There is a section that factors a given weathers "rainfall commonality curve" into the relative rainfall present on that tile.

I am not sure how well I could modify either of these sections non-destructively with WeatherControl.

Could it potentially be an issue with the uncompromising fires mod?

Does this override the rainfall stat? I'm using it with regrowth: expanded world generation right now and despite my sea ice settings being extremely snowy/rainy, the vast majority of the weather is just clear which I'm assuming is related to the 60mm/yr of rainfall on the tile.

@spaceprogram444
I have had a report like that before, but I cannot fathom how or why some other mods loading before this one would break its entry in the mod menu, could you provide more information? When the settings don't show up, are there any errors in the log that I could analyze?

for everyone who are new to this mod and it doesnt work / show anything, you have to push the mod up in your loading list otherwise it doesnt show up in the mod options - thats where u configure stuff.

Thank you for the mod. I'm enjoying making winter colder and summer hotter, for more of challenge.

@Spirehawk
You have to provide a log for me to analyze.

okay... i moved both weather control and nightmare up a couple steps and it dissapeared again, seems i can only see mod options for some strange reason if i have them on the bottom of the load order

@Spirehawk
Sadly an issue with steam and the way it downloads mod updates... Have had problems like that multiple times now, don't know a good solution, the resubbing only works for a select few, others need to verify files, hard to know what to tell those that have issues...

@NightmareCorporation
alright yeah, unsubscribing and resubbing to both causing them to redownload fixed the issue and gave me the menu back. tyty

@Spirehawk
That sounds odd, but I did push an update to this mod and NightmareCore (the dependency for this mod) yesterday. It's possible that your steam client only downloaded one side of those updates. From what I have been told verifying the file integrity through steam should pull the most recent versions and that hopefully fixes your issue.

If you still experience issues, I will need a log to analyze - use this mod https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=2873415404&searchtext=hugslib and share the link.

Or copy your local log from this path "C:\Users\<USER>\AppData\LocalLow\Ludeon Studios\RimWorld by Ludeon Studios\Player.log" into a web service like https://pastebin.com/

Issues should be fixed. If you are greeted by two red errors on startup due to scribe issues, you need to verify your game files through the Steam client. That's the only way to force workshop items to download the latest version of all mods from what I know.

I just realized that an update to the NightmareCore Framework broke the settings features for this mod. I am working on fixing the issue and will post here once they are resolved.

@Squatchsloth
Probably an error while trying to draw the settings? I can't reproduce anything like that with the uploaded versions, can you provide your local log? To share you can copy it from your local log folder (C:\Users\<USER>\AppData\LocalLow\Ludeon Studios\RimWorld by Ludeon Studios) and upload it to a service like https://gist.github.com/

I seem to be having an issue accessing the mod options. whenever I try and click them, a blank window opens up and I'm not able to close it, and am forced to quit the game. I tried looking for a solution but maybe Im dumb and just didn't see it. the mod looks awesome and I would love to mess around with it

Yeah, might have been a glitch on my side. The floor the thing was built on vanished, and so did it. But it wasn't the station's fault.

If you are curious, so the wind turbine was at 0% for a few minutes (when i reported the issue) and now it is constantly producing 3450 watts at all times. Weather is 99.9% set to windy (might be from another mod, i thought it was from this for some reason) or a 0.1% chance of hurricane.