It usually doesn't need an update. Are you having trouble?

update？

@Madmartigan sorry for missing your comment, yeah, this works and will likely never break. (crosses fingers).

still works?

Just pushed a new update after getting some modder feedback, try it out lemme know what you see.

I started a thread on da modding den's development forum to see if we can get some help.

https://discord.com/channels/373745291289034763/1074845082399801435

the problem with that is, that lords will receive 20% moment and 30% sight, agent_to_parent_army_general, is being activated by lord as well.

Oh I already fixed that for campaign movement range and line of sight. You have to make a second effect that does the same thing as the first effect (movement, sight, etc), and give the character both effects, so you can use character_to_character_own as the effect scope to one and agent_to_parent_army_general for the other effect.

However campaign speed, and line of sight behave differently character_to_force_own_unseen effect scope is incorrect and does not work on either character type.

character_to_character_own is working well on lords.. The modifiers have no effect while hero is attached to army. (and campaign bonus is not working even when hero is unattached)

agent_to_parent_army_general_own applies for both lord and hero in army. Unfortunately this does not work for unattached hero.
Still it is probably BEST solution i was able to come up with.

I have looked into campaign_effect_scopes_tables, and the "agent" part of the scope is misleading, the source of the scope is "character". When it comes to source and target of scope it can be "character" and "character_when_commanding" so there is actually no way to specify "hero".
Unless i am wrong, there is no way to make hero get bonus both in army and outside of it without giving double buff to lord, or give hero and lord different trait.

So sorry it took me some time, but i did some more testing, I assume that most effects are working correctly as they are fairly simple.
There were however 4 skills i was not sure about
movement_range, line_of_sight, agent_action_success_chance_enemy, and ambush_attack_success_chance.

i do not know if there is a way to test agent success action chance, but in vanilla it is used only like this: character_to_character_own, character_to_character_provincewide, and character_to_character_own_factionwide
Maybe it can work with army as well, but it is never used.

When it comes to ambush attack success chance, i was excepting this to have similar problem as the next two modifiers, but surprisingly "character_to_force_own_unseen" is effect scope that is working correctly on both hero and lord.

Thank you for answer and sorry that i keep bothering you with different mods.
I dont really understand the percentages how they are calculated.
Before you updated the mod i did not have time to test the lord, but i have tested both character types after update.
When it comes to your update now the movement speed definetly works when it comes to hero in army. My Eltharion in sfo starts with 120 movemnt points(110 + campaigner trait), it is improved to 135 after getting 15% from his first blue skill and his unique skill. When Cavill joins him and has watcher buff Eltharion gets 145 points.

However, my Archmage gets 20 points instead of 10.

It seems like agent_to_parent_army_general_own scope is working for lords as well.

Just pushed an update. Lemme know what you notice. Thanks for the bug report!

I'm trying to make a copy of the movement effect (renamed) and making it apply from agent to parent army general. I'll let you know what I see once I get a few Watchers.

I'm not sure, though when I was making the mod I quadruple checked on The Modding Den that the effect "wh_main_effect_agent_movement_range_mod" with the effect scope "character_to_force_own_unseen" would work. Does it seem to work when you make a general a Watcher? I'm playing Eltharion now I will try to keep an eye out.

Sorry, but can i ask how can you reliably test if the movement range is actually working? When i scroll to the movement range, it shows u percentage, but now it also shows you points. And for example on my Eltharion it shows he has 136 points, but when i get watcher trait on Cavill the number has not changed. I tried to remove him from army and give him back, and i tried to wait a turn if it gets updated, but even then it still showed me same 136 points.
I am not really sure, maybe the points mean something else, or they are bugged, so is there some way to reliably test the movent range?

Ah right! I thought that you might have mis-keyed or something. That's ok, will try it out and see how it does :D
Oh yeah I hadn't even considered multiple heroes, so great call! Ok I will give it a play soon then!

Thanks for the feedback. The 0% physical resist on the sentinel title is me cancelling their 10% physical resist in favor of ward save. Feel free to give feedback later on I recently nerfed the values a bit because you can stack a few heroes in an army for instance with the watcher title and get mass campaign movement range and lots of damage and missile resist when attacking.

Shadow has the least combat utility but that ambush chance is killer. I tend to make mages shadows so my army can get 95%-100% ambush chance in almost all terrain.

And it doesn't seem OP at all, seems pretty balanced other than the Shadow which has 7% bonus for missile units - I'm not sure about that one benefit, if it is a little too much or not as you can also get missile unit dmg increases via skills from generals....I'll have a look at what skills offer that increase and add it all up with this in mind.

The Sentinel has 0% in the effects of the title - was that intentional?