next try, 18 months later:

1.6 plz?

1.5 plz?

@Allyina:

There was some interest in updating this to 1.5, but not only the source code is pretty much “all rights reserved”, this mod’s license prohibits derivatives. Just wanted to let you know in case you intended your work to last indefinitely when you made the source code available.

Hello, I very much enjoy(ed) your mod, but you should know that rimworld has updated to 1.5. Should you return to play the DLC, please remember to update your mod if you manage to find the time.

The ritual screen shows that the expected quality is 100% (fast mover weapon with fast walker pawn trait) so 25% base + 85% bond strength for 100% expected quality. However, the ceremony always results in a terribly or normal bond and the post ritual message says the expected quality was 25%. I have both mod config boxes unchecked, so it looks like the actual calculation is not using the same math as the ritual screen? Any ideas.

the ritual wont be available if you have the ideology system inactive but still have the dlc content enabled. is this intended?

Not certain, I doubt it would cause any issues but the ritual almost definitely wouldn't be available for the warcasket persona weapons

is this mod compatible with the warcasket persona weapons mod?

Just FYI I have an update ready for 1.4. I will push it when vanilla persona weapons expanded is also updated.

@Soraya I'll keep it in mind, it is a lot of grunt work. So much so, that I'd like to come up with an alternative for traits from mods. The issue is it requires a patch operation add to add my def extension to every single trait where everything has to customised with its own weighting.

very understandable! although a lot of the new traits are slight variations on one another and so could probably function the same as one another.
and lmk if you do decide to make it compatible with that mod eventually and would like some help, I'd be happy to make a spreadsheet with some suggested agreeing traits or do the gruntwork of copy/pasting/editing lines of code.

@Soraya It does not, hadn't seen that mod yet. That mod also adds a tonne of traits lol. I like the idea of that mod, just that many traits would be very time consuming. I may do something in the future for it, but not right now with 1.4 looming.

does this take the persona traits from "more persona traits" into account for ritual quality? I feel like that would be more important than every pawn trait from all the trait mods various people prefer :)

this mod is excellent though, I love things that add more narrative immersion.

i like this idea also, it could be better if there is a patch with the "more practical traits" , i always have that trait mod in run

Update 1.2:
Fixed damage multiplier and hit chance not applying as expected.
No longer require the persona weapon is in storage. It just has to be reachable.

Yeah, definitely better than having a performance drain for something used quite rarely; not really a problem so long as one doesn't immediately try to bond a newly acquired weapon without knowing how the cache thing works.

Yup, it sucks because its also time unpaused. I hate that I need to cache it. But if I don't there would be bigger issues. Rimworld likes to check if it can start a ritual on whatever you have selected constantly.

I'll be damned, that was it; I could've sworn I waited longer than that while testing it, but I might not have waited longer than that since placing the stockpile zone.

Oh I should also note, I have to have an awkward 600 tick (10 seconds at 1x speed) cache on the gizmo (button to start ritual) showing due the wonky way show gizmos works for rituals. Otherwise it would kill performance. So that might've caused confusion. Like if it just got put into storage you have to let a little time pass.

Hmm, it shouldn't. What mod was the persona weapon from?

Also was the modded persona weapon in storage? It only shows the option when its in storage. However I can see a situation where what you describe can happen. If one persona weapon is in storage, and the other isn't. The storage was because persona weapons in ancient dangers were causing awkward issues. Once in the UI though, I have much more information available to confirm the location. However I might have a better way to check.

It seems this mod works for persona weapons added by other mods, but for me the ritual only showed up when a vanilla / vanilla persona weapons expanded weapon was in storage. As such, using devmode to add such a weapon and removing it afterwards did the trick.

@Random Tank I'll investigate further when not jet lagged. But I believe you are correct, I was operating on the assumption the stat factors applied to the weapon, but they apply to the pawn. So with it equipped your pawn is 15% more effective as a weapon! This is quite impactful... Will try to get something updated for it soon, but might not be until Im back home next week.

As far as I can tell, the true bond doesn't seem to actually boost the damage of the weapon at all; I just got one on a masterwork quality plasmasword, and the pawn's melee verbs say that a slash attack is doing 33.4 damage, which is exactly the same as a non bonded one.

Also, the melee hit chance boost is not correct (I'm assuming); it only gives +0.1 hit chance, when an additional level of Melee Skill gives +1. Meleehitchance is not a % boost, it's a flat numerical figure, so it needs to be 1 or 5 or whatever, not 0.1.

Don't know what you did, but the fix works perfectly, thanksies.

Okay, I have pushed an update to maybe help. Its a mod conflict or other weird issue. I can't say, as I can't replicate. Hopefully it solves it though

at RimWorld.Dialog_BeginRitual.PredictedQuality (System.Single& potentialMax) [0x00069] in <81af9f8a18324e17b286924a43555a7c>:0
at (wrapper dynamic-method) RimWorld.Dialog_BeginRitual.RimWorld.Dialog_BeginRitual.DoWindowContents_Patch2(RimWorld.Dialog_BeginRitual,UnityEngine.Rect)
at Verse.Window.InnerWindowOnGUI (System.Int32 x) [0x001d3] in <81af9f8a18324e17b286924a43555a7c>:0
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch3 (string)
Verse.Window:InnerWindowOnGUI (int)
UnityEngine.GUI:CallWindowDelegate (UnityEngine.GUI/WindowFunction,int,int,UnityEngine.GUISkin,int,single,single,UnityEngine.GUIStyle)

Exception filling window for RimWorld.Dialog_BeginRitual: System.NullReferenceException: Object reference not set to an instance of an object
at Verse.GenCollection.Any[T] (System.Collections.Generic.List`1[T] list, System.Predicate`1[T] predicate) [0x00000] in <81af9f8a18324e17b286924a43555a7c>:0
at (wrapper dynamic-method) PersonaBond.RitualOutcomeComp_BondTraits.PersonaBond.RitualOutcomeComp_BondTraits.CountInternal_Patch0(PersonaBond.RitualOutcomeComp_BondTraits,Verse.Pawn,RimWorld.Precept_Ritual,string&,PersonaBond.RitualOutcomeComp_BondTraitsData)
at PersonaBond.RitualOutcomeComp_BondTraits.GetExpectedOutcomeDesc (RimWorld.Precept_Ritual ritual, Verse.TargetInfo ritualTarget, RimWorld.RitualObligation obligation, RimWorld.RitualRoleAssignments assignments, RimWorld.RitualOutcomeComp_Data data) [0x00013] in <cf64b697d0654e54bf30155f62958f45>:0

Do you have a log? Dont have any issues testing.

So uhhhh, I tried to do the ritual with a slave.... and the UI broke and now I cant fix it....

Thanks so much!

Thank you for the added support, my friend! i look forward to seeing what other projects you release.

v1.1
- Added bond strength consideration for RimTraits - General Traits
- Added support for non Vanilla Persona weapons. You wont get to customise, but the rest should work.

@Allyina I'd like to respectfully second the request for "RimTraits - General Traits" support! Thanks so much for a cool mod :)

@RaptorMother It only works with the Vanilla (VE ones). It would work with others should they add the Vanilla Framework customisation, though dont go bugging anyone for it. That's up to them

@CaWafer I'll take a look, if they dont add traits it might be tricky. But if they are modifying stats like psychic sensitivity/pain threshold then it will work already (that's part of individuality compatibility as well but applies to everyone)

@Drekkenought I'll take a look and consider it!

Would you be willing to add compatibility with "RimTraits - General Traits"?

The pitch is top notch! I did play a bit with it, added it to a playthrough in session and didn't see a ritual pop up. Is it limited to the persona weapons from vanilla/VE Personas, or does it work with any persona weapon added by any mod?

It isn't a traits mod but would you be able to make this mod work with 1-2-3 Personalities? I'm not sure if they could work together somehow but if so it could add extra personality to the bond. The thinking personality could be better with psychic sensitizer weapon trait, instincts with painless/fast mover, and thinking with calm thoughts/kind thoughts.

Yes :P But I wont spoil them yet. Next one will be back on Alpha memes because it fits there.

loved the ideia , loved the funerals too, any other cool rituals in the plans?