Version 1.6.1
Added check to ensure only primary-equippable items are reloaded

---

@nanufrog
Should be fixed. Items that can't be equipped will no longer be attempted to be reloaded via this mod's logic (from inventory etc.).

Hello!
This seems to conflict with VFE:Pirates, particularly the Shock Warcasket which uses Chemfuel to jetpack/drop-pod transport pawns to other tiles on the worldmap. When pawns attempt to reload the Warcasket with chemfuel from inventory, it will remove the Warcasket from that pawn and give the 'Tried to set non-primary equipment as primary' error. Removing Yayo's Addon resolves the issue.

https://gist.github.com/HugsLibRecordKeeper/fac20533f38e2e1595e337620bda1355

Hm...unsure how that mod works. I'll note it down, might look into it at some point. No promises though

Hello, loving the mod, would like to know if could be possible to make something to be able to reload the underbarrel attachments introduced by modular weapons 2 for example, thanks in advance and again, the mod is awesome

Thank you for the testing
Though it sounds like there is nothing I can do, so hopefully the other mod's authors figure it out

I have isolated the problem to be between Yayo Combat and Animal Apparel Framework, see Mile's discord for further logs etc.

I'm having the same issue as Darkmoon. I haven't made much headway with tracking down the cause so far except for a few observations:

1) I ran a different combination of mods earlier, with the addon, and without ever getting this error.

2) Removing Altered Carbon but keeping the addon did not fix this error.

3) Removing the addon did not fix this error.

4) Removing Yayo Combat itself finally did fix this error.

So currently I believe it is some sort of incompatibility between Yayo Combat and another mod, and is actually unrelated to this addon.

No idea. Not sure I understand that error report correctly tbh, but even if I do, there is not enough information there to narrow down what could be causing it.

Does the error go away when disabling the addon mod?


Also, another mod may be involved seeing "Altered.Carbon" in the stacktrace. Don't know that mod though

I get this error every few seconds in the console, and I can't figure out what might be causing it:

https://codefile.io/f/msoLkUZZat

Oh I see. They do finish the kill first before going back. Thanks for the clarification!

I think hunting and hauling are two separate instances, since I sometimes see other pawns hauling the corpse while the hunter goes back to reload

Previously hunters would go back after firing a few shots, with this mods they will keep on hunting until out of ammo or the hunting task ends.
Going back to reload after killing their target might be because the hunting task ended and instead a hauling task starts. Not sure if hauling the kill back still counts as hunting.

Maybe they changed something though, this mod only checks for the hunting job, maybe they added a new job for hauling the kill...not sure

"- Fixed hunters going back to reload all the time"

I am still getting this issue. My pawns seems to prioritize reloading over hauling their kills after hunting.

So it goes like Kill > Go back to base to reload > Haul.

Many thanks! Very excited to have this one =D

THANKS A LOT

YOU ARE GOD

Wooooooh! Thank you!!!

@Flapdoodle Thanks for the heads up on the github update

1.6!!!!!!!

Hi, Yayo's combat is updated to 1.6. Really thanks if you can update it! Thank you

Hey Syrus - thanks for all of your work with this and your other mods! Politely showing interest in a 1.6 update now that the main mod had ported over.
Either way, appreciate all of your contributions and the added joy they provide =D

Very excited for the 1.6 update!

Main mod is updated to 1.6. Waiting for the sun addon!

Yayo's Combat itself needs to be updated first, can remind me after that!

Only love for this mod. Hope for 1.6 ofc :D

Are there any tools out there to manually configure what kind of ammo certain weapons use (if at all)? Some mods, like VWE Heavy weapons and the Warcasket weapons don't consume ammo at all, and some like Milkwater's Pipe Gun Mod make the normal weapons use special class ammo. A utility to manually configure which ammo is assigned to each gun would be really useful to fix these incorrectly automatically assigned ammo designations.

Also works fine with the "shooting a few bullets" recreation activity with the training dummy, only reloads from a pile after the activity is done.

Might be a bit of a compatibility issue with the Misc. Training mod. I think the issue is with the Training task and not the target dummies themselves. Colonists assigned the task will shoot at the target dummy but will go to reload out of a stockpile (ex. pile of arrows) every three or four shots. You can right click and tell them to practice shooting at it and they will use up their ammo, but not if they do it automatically when assigned the training task.

@dabeek
Probably better to recommend that on the main mod itself, sounds like a good idea to me, let me know how they respond to it

Minor suggestion: Could you reclassify ammunition as Travel Supplies in the caravan menu? It'd make it a bit easier to find in the item list, and it would also be a better categorization.

will it try to be compatible with multiplayer...? Your mod is excellent!

Dear mod author, this mod is great, but my character used to automatically reload his weapon after consuming ammo, but now I can only reload manually. What's wrong?

It's kind of an issue with base game RimWorld and using its methods to look for available ammo, and it's an issue for both the Yayo's Combat base mod and this addon.
It could likely be fixed by checking if the pawn looking for ammo is of the player faction and disallowing all player-stockpiled ammo in that case, but doing so would likely be more difficult to do than it sounds like.

Keeping the ammo stockpile away from where fighting occurs and limiting the ammo search range in the settings might help, as I think visitors only look for ammo when reloading.
Or just see it as a tax for using neutrals to fight your battles...

为什么中立派系会到我家储存区拿弹药？

Confirmed working, thanks!

Steam failed to update it on your end, it does that sometimes
Try un- and resubscribing to the mod to force an update

Unless the mod failed to be updated by Steam, and even after restarting, I still get the error.

Error in static constructor of YayosCombatAddon.HarmonyPatches: System.TypeInitializationException: The type initializer for 'YayosCombatAddon.HarmonyPatches' threw an exception. ---> System.TypeLoadException: Could not resolve type with token 01000085 (from typeref, class/assembly yayoCombat.patch_Pawn_TickRare, yayoCombat, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null)

Wow!

Version 1.5.3
Updated for renamed Harmony-patches in Yayo's Combat (Continued) Version 1.5.4

Hello there,
The main mod Yayo combat has been updated by Mlie and after some clean up, it triggers an error in this mod, can you take a look please? Thanks.

Version 1.5.2
Fixed assign tab ammo columns being inserted after "remaining space"

Oh thanks, for some reason my save didn't load the mod, I was about to comment bout' that till you commented. But thanks anyway!

Checked it, both the fueled and electric smithy should be able to craft all primitive ammo types.

That should already be part of this mod, unless the patch for it does not work (anymore)?

Is there a way for you to add the primitive ammunition blueprint to the smithing table? Since that would make sense in a realistic sense.

Is it part of Yayo's Combat?

Can you add Bioferrite as an ammunition type for pawns to carry? It reloads the Anomaly charges on the Hellcat Rifle.

Version 1.5.1
Added settings to reduce ammo dropped from inventory or in/ejected from weapons for downed/killed enemies/allies so that acquiring ammo can be made more difficult
Increasing Yayo's Combat's "Base ammo capacity" adds ammo in inventory instead of increasing the ammo in the magazine beyond its capacity for spawned weapons (e.g. on raiders and starting weapons)

Tested it, didn't see any premature reloading, neither when forcing a pawn to train, nor when they did it for fun. I'm probably missing something, got any more info on when this occurs specifically?

Not a huge issue, but is there any way to make it compatible with the misc training mod?
Its basically the same issue with pawns going to reload prematurely when hunting, but instead its when they're shooting at training dummies. They shoot 2 or 3 shots and leave to go reload. I have a temporary workaround for now, but whenever you're tinkering around again, maybe have a look into the issue? Much appreciated, and thank you for all you've done so far. One of the best mods for the game, hands down.

Thank you!