Newest update fixes the bug, both with and without other mods. Thank you for your attention on this.

It's the same as issue #13 on Github. https://github.com/Ishigh1/RecursiveCraft/issues/13
I'll add the error from my last test with just this mod over there.

I will need a more precise error than that, I don't really have the time to test stuff myself

This no longer works. Attempting to pick up an item results in a softlock due to a NullReferenceException in RecursiveCraft.RecursiveSearch.DiscountRecipe. It also, for some reason, prevents opening the inventory.

I tried checking in the Discord, but that "captcha" bot linking off-site and asking for login is just a blatant attempt at phishing.

For everyone talking about Magic Storage compatability, MS has it's own recursive crafting in the config.

Im on 1.4.4.9 and it doesnt seem to be working.

"I'm not the one handling Magic Storage integration, ask the maintainer of MS"

could you make a ticked? maybe you need to supply them with infos etc.

I'm not the one handling Magic Storage integration, ask the maintainer of MS

Yes, it's a very good mod, but it doesn't seem to be working in Terraria 1.4.4 with Magic Storage

You may reduce the crafting depth to mitigate the issue

TW has a lot of recipe that require other recipe, unlike other crafting stations that usually go up to depth 2 by requiring a bar that is made of ore

i see, seeing as how you said its exponential id assume the Tinkers workshop is unlike any other crafting station as even its just the TW alone it creates issues, even if i am not near any other workstation, and likewise if i use some mods multi-combined station (IE a furnace anvil heavy workbench crystal ball solidifier wooden workbench all in one item) there isnt any lag as long as there is not a TW in the work station pool that is in the fused workstation(if that makes sense? im not sure as i am pretty tired at the moment lol)
but im just going to assume it has to do with what you said plus how the TW works

Well trying to find all the recipes is NP-complete and I essentially bruteforce it, so yeah, the time needed to find all the recipes is exponential, so it can only be solved with a better algorithm that I didn't find

why has the stupid Tinkers workshop bug that crashes or severally lags the game for 30-inf seconds still exist. this stupid bug has existed for at least a year and still no fix for it?
is it unfixable or something?

It should ?

Still works?

That's funny because Magic Storage is the one handling the compatibility

Getting a hard crash when right clicking on the crafting interface in Magic Storage. Definently incompatible, no error logs.

Seems to be a cool mod, but if it's incompatible with magic storage AND recipe browers it's a no-go for big modpacks, or even big mods, such as calamity.

Libraries are annoying to use in tmod though

@IsHigh: I didn't mean in memory, I was thinking on-disk. Something like the graph equivalent of SQLite maybe

All recipes trees would just make an out of memory error, I tried already
Didn't know there was an issue with recipe browser though, will look into that

@HallowedFlux: Do you have Recipe Browser installed? There's a hard incompatibility between Recipe Browser and Recursive Craft.

@Ishigh: What about pre-calculating all recipe trees on world load and then just doing a lookup based on the player's inventory?

I don't have the logs rn as i've already swapped mods a few times since then, I'll enable it again and if it crashes again then I'll post a discussion with the logs

Can you share the logs ?

Seems to crash at random while enabled alongside magic storage and calamity especially when dealing with a lot of items (as in 2000+ slots worth of items.) Crash happens regardless of loading time while swapping or crafting items.

Also the time it takes to calculate the recipes doesn't seem to change if I set the recursion from -1 to 1, not sure if that's because of how it's written or just an engine limitation?

Don't worry, loops can't happen, I forbid to use the same recipe twice in the same branch of a crafting tree
It's just very slow to explore it

I think the issue with lag spikes caused by the tinkers workbench is due to recipe loops. You could try adding a callstack to the recursion to keep track of which items already have recipes to make sure something isn't trying to use itself when crafting

I didn't find a way to make it more optimized unfortunately, I have absolutely no idea of how I could do unfortunately

Last time I used this mod was about a month ago, has the major issue involving the tinkers workbench been fixed yet? (Where whenever you open an inventory near it it lags for a second then freezes for several seconds, then lags/becomes very choppy after it unfreezes for a few seconds, and then whenever opening up the hammer icon (all craftable recipes) it lags and freezes again, and whenever you craft/place in or throw out of one's inventory it does the same issue as above.)

It works now! Thank you so much

Should be fixed

Don't know, I think it will be, it's just that I have to download the preview version, thing I didn't do

Ah, that's not a quick fix thing, is it?

Oh you're on Preview, that changes things

@Ishigh it's still not working for me. tModLoader (v2022.10.17.0 preview 1dbf7cfb) says Recursive Crafting (v1.0.1.3) is built for tModLoader v2022.9.47.4

Should be fixed

This mod will not load with the newest tModLoader version, otherwise it's a 10/10 must-have

You can open a new discussion

oh also its a picture

hey where do i post bugs, i found one thats annoying but doesnt break the game

Oh uhh they just updated? That's cool. Thanks then.

"MagicStorage (Magic Storage) v0.5.7.4"
Latest is 0.5.7.6, the issue should be fixed there

The last few lines are me opening the crafting interface and encountering the bug

https://pastebin.com/jmDBzuWL
Here is the client.log

It happens when I only have recursive craft and magic storage on. I'm using the latest versions of tmod, recursive craft, and magic storage.

Can you put here all the mods you're using along their versions and tmodloader's ?

Mod has stopped working with the newest magic storage mod.

It probably is the issue

Infinite crafting bug
Well, I can craft without ingots but with ores ( cool, it was supposed to work like that ), the problem is that it doesn't consume anything other than ingots i don't have.

I used that in combination with " better crafting interface " but I don't think that's the combination problem.

got the same issue as Kronny, but had no error in my server or client log, i only had a few second lag after changing the setting of the mod to only one depth if it can help.
i didn't try without fargo, but could it be because of the different crimson/corruption swapping recipes ?