RimWorld

RimWorld

[WYD] Worthless Junk (Adjusted)
Error After Update
[[WYD] Worthless Junk (Adjusted) - Start of stack trace]
Verse.PatchOperationReplace(xpath="Defs/ThingDef[defName="AncientKitchenSink"]/graphicData/shadowData"): Failed to find a node with the given xpath
Verse.PatchOperationSequence: Error in the operation at position=11
Verse.PatchOperationFindMod(Dubs Bad Hygiene): Error in <match>
[End of stack trace]
Source file: D:\Steam\steamapps\workshop\content\294100\3497961373\Mods\1.6\Dubwise.DubsBadHygiene\Patches\WYD_AncientHygienePatch.xml

[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.UnityEngine.StackTraceUtility.ExtractStackTrace_Patch1()
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.Log.Error_Patch2(System.String)
[XML Extensions, XmlExtensions.dll] XmlExtensions.ErrorManager.PrintErrors(System.String source, Verse.ModContentPack mod)
[XML Extensions, XmlExtensions.dll] XmlExtensions.PatchOperation_Patch.Postfix(Verse.PatchOperation __instance, System.Boolean& __result, System.Xml.XmlDocument xml)
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.PatchOperation.Apply_Patch1(Verse.PatchOperation, System.Xml.XmlDocument)
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.LoadedModManager.ApplyPatches_Patch2(System.Xml.XmlDocument, System.Collections.Generic.Dictionary`2[System.Xml.XmlNode,Verse.LoadableXmlAsset])
[Core, Assembly-CSharp.dll] Verse.LoadedModManager.LoadAllActiveMods(System.Boolean hotReload)
[Core, Assembly-CSharp.dll] Verse.PlayDataLoader.DoPlayLoad()
[Core, Assembly-CSharp.dll] Verse.PlayDataLoader.LoadAllPlayData(System.Boolean recovering)
[Core, Assembly-CSharp.dll] Verse.Root+<>c.<Start>b__10_1()
[Core, Assembly-CSharp.dll] Verse.LongEventHandler.RunEventFromAnotherThread(System.Action action)
[Core, Assembly-CSharp.dll] Verse.LongEventHandler+<>c.<UpdateCurrentAsynchronousEvent>b__28_0()
[System, mscorlib.dll] System.Threading.ThreadHelper.ThreadStart_Context(System.Object state)
[System, mscorlib.dll] System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx)
[System, mscorlib.dll] System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx)
[System, mscorlib.dll] System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state)
[System, mscorlib.dll] System.Threading.ThreadHelper.ThreadStart()

and

[[WYD] Worthless Junk (Adjusted)] Patch operation Verse.PatchOperationFindMod(Dubs Bad Hygiene) failed
file: D:\Steam\steamapps\workshop\content\294100\3497961373\Mods\1.6\Dubwise.DubsBadHygiene\Patches\WYD_AncientHygienePatch.xml
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.UnityEngine.StackTraceUtility.ExtractStackTrace_Patch1()
[Harmony, 0Harmony.dll] MonoMod.Utils.DynamicMethodDefinition.Verse.Log.Error_Patch2(System.String)
[Core, Assembly-CSharp.dll] Verse.PatchOperation.Complete(System.String modIdentifier)
[Core, Assembly-CSharp.dll] Verse.LoadedModManager.ClearCachedPatches()
[Core, Assembly-CSharp.dll] Verse.LoadedModManager.LoadAllActiveMods(System.Boolean hotReload)
[Core, Assembly-CSharp.dll] Verse.PlayDataLoader.DoPlayLoad()
[Core, Assembly-CSharp.dll] Verse.PlayDataLoader.LoadAllPlayData(System.Boolean recovering)
[Core, Assembly-CSharp.dll] Verse.Root+<>c.<Start>b__10_1()
[Core, Assembly-CSharp.dll] Verse.LongEventHandler.RunEventFromAnotherThread(System.Action action)
[Core, Assembly-CSharp.dll] Verse.LongEventHandler+<>c.<UpdateCurrentAsynchronousEvent>b__28_0()
[System, mscorlib.dll] System.Threading.ThreadHelper.ThreadStart_Context(System.Object state)
[System, mscorlib.dll] System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx)
[System, mscorlib.dll] System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx)
[System, mscorlib.dll] System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state)
[System, mscorlib.dll] System.Threading.ThreadHelper.ThreadStart()
< >
Showing 1-8 of 8 comments
Monkey Magic  [developer] 21 Aug @ 4:23pm 
First I'll reiterate what I posted on the thread:

"I can only assume you are running some other mod that is causing an issue here. I have tried testing the mod by itself, and there are no issues. I just updated with a load after requirement for Dubs Bad Hygiene coz apparently I didn't save that change to the About file last time, and loading in the wrong order could cause errors - but those are different to what you are reporting :/"

Now I'll elaborate:

When loaded in the wrong order, it throws up an issue stating Could not find parent node named "BasedFixture" for node "ThingDef". because it can't access the info it needs in that mod. But this isn't the issue you reported, so yeah It's probably not that.

I would suggest first unsubbing to this mod, and resubbing. This should clear out any corrupted files in case the mod didn't download correctly, or something. If that doesn't fix it, disable any mods that either:

- change ancient stuff
- affect Dubs Bad Hygiene
- have any relation to the specifics of the error report.

Then you can figure out which one is the problem. If you can go ahead an post a link for your modlist, that would be helpful. I am running over 200 mods, and have no errors, so it's likely to be another mod that's causing the problem here.

That Said

The first error is regarding a change to the shadow data. This patch effectively removes the shadow data, so it failing to patch won't be a serious problem, it'll just load the vanilla shadow data. It's not failing on my end however, so I'm curious if you have some modthat affects shadows or something here..

The second issue i the game failing to find Dubs Bad Hygine for the patch to work. If you don't have that mod in, then it shouldn't (and does not) run in the first place. The other option would be having the in the wrong order as mentioned above, but yeh. Different error
Last edited by Monkey Magic; 21 Aug @ 4:32pm
Dubs is definitely loaded after and I don't *think* I have another mod messing with ancient junk specifically.

Here's my current list(sorted in RW, just used RimSort to get the link):

https://rentry.co/4u7k4th9
OH and I did try to resubscribe to them first, still get the same.
Monkey Magic  [developer] 22 Aug @ 5:14pm 
Testing with just the Core game, all the DLC, Worthless Junk Adjusted and the DBH Addon: Expanded Pack enabled, I get errors when the latter mod is enabled before the former one. Seems to have no issue when the load order is reversed, but that's only load tested, no actual gameplay.

For your modlist: try disabling the DBH Addon mod, and see if the error persists without it. If it does, then it's likely not the main issue. If the error is gone when it's disabled, you found the culprit. You can then either leave it out of your modlist, or try enabling it after WJA and see if the issue resolves - but inno what changes that mod makes, so iunno if it will overwrite changes made by WJA.
I'm trying it with them reversed and so far(after like 10 minutes and some god mode) it seems to be all fine.. . . .
IDK if you'd be willing to, but could you make the DBH patch optional or if it detects the addon to not run?

It might just be fine to set load before the addon pack or something?
Monkey Magic  [developer] 22 Aug @ 7:29pm 
I looked further into it, and the two mods are fundamentally incompatible, both practically and thematically. I would suggest not using them together, even if the load order is set so they do not conflict - and here's why:

Worthless Junk Adjusted is primarily about getting value out of junk. For the most part this is just a material compensation for the pawns work in deconstructing, or demolishing the item; but in the case of Dubs Bad Hygiene I added a patch that allows some additional value to the Ancient Toilet and the Ancient Sink because with Odyssey DLC, the player is more likely to be exploring the map in general, rather than staying with a single tile.

My approach to this was to make the toilet viable as a temporary latrine, and the sink viable as a water container. This makes the ancient toilet usable immediately, but once full, it can not be emptied like a true latrine - although it can still be destroyed for it's resources*. The ancient sink must be refilled by hand, like the water basin. Neither of these buildings are claimable, so they can not be moved from their spawn location**.

The approach taken in DBH Addon: Expanded Pack is to restore full functionality of these items. They are essentially the same as existing buildings in DBH, that the player does not have to build, but they can not be uninstalled. Given that they are completely useless until the player has reached the technology level to plumb them into a sewage grid - and by that time the player can just build their own anywhere they like in any case - I don't really understand why they bothered.

As a re-texture mod, the DBH Addon is perfectly fine. The introduction of Royalty DLC themed buildings are a nice addition, but the patches to the ancient buildings make little sense at all.¯\_(ツ)_/¯

****************************************************************************

*This is also why I included the {i]Relieving Spot[/i]. If no ancient toilets are available (or those that are have been filled/destroyed) this building becomes the only other resource free option.

**This assures that upgrading to a constructed latrine and wash basin when the player has the resources worthwhile progression.
Last edited by Monkey Magic; 22 Aug @ 7:29pm
One could argue both mods go a little bit out of their respective scopes(but barely, I could see it making sense for either as well); Dubs should just make it his mod that effects anything involving hygiene.

I tried to do a patch myself (I don't like editing actual mods because updates) with AI helping and couldn't get anywhere, so I'm just gonna run it like this and hope nothing harmful happens later.
Also I appreciate your time looking into it and stuff!
< >
Showing 1-8 of 8 comments
Per page: 1530 50