I'm not sure if the dev of Superb Survivors is still actively working on this mod. I'd say go for it, be prepared for the mod author (to come back and) ask you to take down your mod and submit your changes to him.

To be fair, both are a win-win. You fix the changes and mod works again, OR you fix the mod and the author wants you to submit the changes and take down your version, but the mod is still fixed.

ye this happend once before its in the faq

{Currently I believe this Original workshop now has copied in most of the many fixes/improvements/features that mod copies have implemented}

^ this kinda is not accurate now and loads of issues reside

personally i also went into the files
i even know of some core functionality issues that are causing bugs
im just not anywhere near the lvl required to go and fix it

but to name a few here

the farmer excessive amount seed issue causing severe lag
movement being frame tied to 60
equipped items being checked for sorting causing loops
the direction of approach when using containers

basically the framework needs more work on the frame
from what i have been looking through its a bare bones code
that feels like its winging it rather than properly guided

it causes it to break it self

like it needs limitations rather then extensions
but maby thats just me tho

if you think you can go for it
you would do a immense favor to a ♥♥♥♥ ton of players for sure
maby just not the credit for it

but not all heros wear capes
like jesus he had no cape either

Originally posted by SchijtHaas:

I'm not sure if the dev of Superb Survivors is still actively working on this mod. I'd say go for it, be prepared for the mod author (to come back and) ask you to take down your mod and submit your changes to him.

To be fair, both are a win-win. You fix the changes and mod works again, OR you fix the mod and the author wants you to submit the changes and take down your version, but the mod is still fixed.

---

... I've reviewed most of the code by now. "Fixing" doesn't seem to be right. I am actually questioning the logic that it is even reasonable for me to do most of the work and then he claims all the credit for that effort by doing nothing until he returns.

-------

Originally posted by Skyver:

ye this happend once before its in the faq

{Currently I believe this Original workshop now has copied in most of the many fixes/improvements/features that mod copies have implemented}

^ this kinda is not accurate now and loads of issues reside

...

Overall, the mod wasn't even nolanritchie's effort alone - the code style and formatting is completely different at a glance compared to what was written 10 months ago vs. what can now be found in the workshop mod folder.

Old Repo by Ryuu (and the actual original team)
https://github.com/DartVonRyuu/SuperiorSurvivors_Revisited/commits/main/client/6_Tasks
- I don't see commits from nolanritchie anywhere in that repo... unless he has a different handle on github.

Current mod folder
steamapps\workshop\content\108600\1905148104\mods\Superb-Survivors\media\lua\client

*There are actually code in the mod that wasn't even created nor written by the author and straight up copied without crediting the code source.

If you're wondering why the bugs and errors are happening, it is likely because he tried to "integrate" (copied) the code from others who have built on top of previous versions of Superb Survivors without fully understanding what is/was being done.

I won't speculate any further than this... because whatever that drama was, I want no part of that.

Originally posted by {5LINE}Cows with Guns:

Originally posted by SchijtHaas:

I'm not sure if the dev of Superb Survivors is still actively working on this mod. I'd say go for it, be prepared for the mod author (to come back and) ask you to take down your mod and submit your changes to him.

To be fair, both are a win-win. You fix the changes and mod works again, OR you fix the mod and the author wants you to submit the changes and take down your version, but the mod is still fixed.

---

... I've reviewed most of the code by now. "Fixing" doesn't seem to be right. I am actually questioning the logic that it is even reasonable for me to do most of the work and then he claims all the credit for that effort by doing nothing until he returns.

-------

Originally posted by Skyver:

ye this happend once before its in the faq

{Currently I believe this Original workshop now has copied in most of the many fixes/improvements/features that mod copies have implemented}

^ this kinda is not accurate now and loads of issues reside

...

Overall, the mod wasn't even nolanritchie's effort alone - the code style and formatting is completely different at a glance compared to what was written 10 months ago vs. what can now be found in the workshop mod folder.

Old Repo by Ryuu (and the actual original team)
https://github.com/DartVonRyuu/SuperiorSurvivors_Revisited/commits/main/client/6_Tasks
- I don't see commits from nolanritchie anywhere in that repo... unless he has a different handle on github.

Current mod folder
steamapps\workshop\content\108600\1905148104\mods\Superb-Survivors\media\lua\client

*There are actually code in the mod that wasn't even created nor written by the author and straight up copied without crediting the code source.

If you're wondering why the bugs and errors are happening, it is likely because he tried to "integrate" (copied) the code from others who have built on top of previous versions of Superb Survivors without fully understanding what is/was being done.

I won't speculate any further than this... because whatever that drama was, I want no part of that.

aha nhaa fair enough no one would blame ya either
like not understanding but just dumping never worked for me either

just a shame its the only one left

fwi go have a search on the discord there's a little something there ; )

Originally posted by Skyver:

fwi go have a search on the discord there's a little something there ; )

Can't comment on that, didn't even know about a discord for PZ modding, only read about the Indie Stone's modding policy.

If you have a link it would help.

Originally posted by {5LINE}Cows with Guns:

Originally posted by Skyver:

fwi go have a search on the discord there's a little something there ; )

Can't comment on that, didn't even know about a discord for PZ modding, only read about the Indie Stone's modding policy.

If you have a link it would help. :ojigi:

ah meant the mod discord and a something else that can,t be mentiond but idk bout public posting and all let me add you real quick
il send the link and gtfo

Originally posted by {5LINE}Cows with Guns:

Originally posted by SchijtHaas:

I'm not sure if the dev of Superb Survivors is still actively working on this mod. I'd say go for it, be prepared for the mod author (to come back and) ask you to take down your mod and submit your changes to him.

To be fair, both are a win-win. You fix the changes and mod works again, OR you fix the mod and the author wants you to submit the changes and take down your version, but the mod is still fixed.

---

... I've reviewed most of the code by now. "Fixing" doesn't seem to be right. I am actually questioning the logic that it is even reasonable for me to do most of the work and then he claims all the credit for that effort by doing nothing until he returns.

-------

Originally posted by Skyver:

ye this happend once before its in the faq

{Currently I believe this Original workshop now has copied in most of the many fixes/improvements/features that mod copies have implemented}

^ this kinda is not accurate now and loads of issues reside

...

Overall, the mod wasn't even nolanritchie's effort alone - the code style and formatting is completely different at a glance compared to what was written 10 months ago vs. what can now be found in the workshop mod folder.

Old Repo by Ryuu (and the actual original team)
https://github.com/DartVonRyuu/SuperiorSurvivors_Revisited/commits/main/client/6_Tasks
- I don't see commits from nolanritchie anywhere in that repo... unless he has a different handle on github.

Current mod folder
steamapps\workshop\content\108600\1905148104\mods\Superb-Survivors\media\lua\client

*There are actually code in the mod that wasn't even created nor written by the author and straight up copied without crediting the code source.

If you're wondering why the bugs and errors are happening, it is likely because he tried to "integrate" (copied) the code from others who have built on top of previous versions of Superb Survivors without fully understanding what is/was being done.

I won't speculate any further than this... because whatever that drama was, I want no part of that.

I've had a look in the code myself and by doing so I'm questiong my sanity. I'm a developer myself, I don't know lua but from what I can understand the code does seem like an intern went on stack overflow and copied a bunch of SO solutions into the codebase, deemed everything functional on the small scale and pushed it to the release branch, while in a scale to mod is being used it just tears itself down. unideal linear, quadratic to even exponential loops. The code doesn't really show this on first glance but what the NPC's are finally carrying out in the game result in these kind of loops.

I have the thing working, not going to touch it either. It's currently the next best thing for NPC's untill build 43.

Originally posted by SchijtHaas:

I've had a look in the code myself and by doing so I'm questiong my sanity. I'm a developer myself, I don't know lua but from what I can understand the code does seem like an intern went on stack overflow and copied a bunch of SO solutions into the codebase, deemed everything functional on the small scale and pushed it to the release branch, while in a scale to mod is being used it just tears itself down. unideal linear, quadratic to even exponential loops. The code doesn't really show this on first glance but what the NPC's are finally carrying out in the game result in these kind of loops.

I have the thing working, not going to touch it either. It's currently the next best thing for NPC's untill build 43.

Well - fixing all the errors being reported by the game isn't terribly difficult... since console.txt reports the line number and file causing the issue (for the most part).

It's fixing the "compatibility" and "AI" that's the challenge.

Frankly, removing all the garbage code and focusing on spawning the NPC/Survivor should have been the priority.

NPC-Survivor Personality, quest management, and custom maps should never have been included.

Originally posted by Skyver:

fwi go have a search on the discord there's a little something there ; )

Well, I took a quick look at the mod's discord... just a bunch of spam and questionable content.

I think I'll stick with GitHub for actual development.

Originally posted by {5LINE}Cows with Guns:

Originally posted by Skyver:

fwi go have a search on the discord there's a little something there ; )

Well, I took a quick look at the mod's discord... just a bunch of spam and questionable content.

I think I'll stick with GitHub for actual development.

Heh, I found that one out myself as well couple of days ago

Quick update: I have sent an e-mail request to the devs (Indie Stone) to take over this mod (I have no idea what is considered "abandoned"... so I went with asking for permission formally).

Regarding the author permissions... I have asked and received permission from Ryuu (another og author who worked on the older versions) to continue updating this mod.

https://github.com/DartVonRyuu/SuperiorSurvivors_Revisited/discussions/52#discussioncomment-5738269

Otherwise, waiting on nolanritchie's response ...

Originally posted by {5LINE}Cows with Guns:

Quick update: I have sent an e-mail request to the devs (Indie Stone) to take over this mod (I have no idea what is considered "abandoned"... so I went with asking for permission formally).

Regarding the author permissions... I have asked and received permission from Ryuu (another og author who worked on the older versions) to continue updating this mod.

https://github.com/DartVonRyuu/SuperiorSurvivors_Revisited/discussions/52#discussioncomment-5738269

Otherwise, waiting on nolanritchie's response ...

Nice going, better to ask for permission than have that drama while you’re in the process of fixing everything. Here’s hoping you get the go ahead

If you manage to get this sorted, I'd be happy to answer any questions you have about the code base. I worked on this codebase a couple years ago maintaining a mod called "Subpar Survivors." I don't currently have the time to devote to maintaining something like this again, but as I said I'd be happy to help in some small way if needed.

Originally posted by SlightlyMadman:

If you manage to get this sorted, I'd be happy to answer any questions you have about the code base. I worked on this codebase a couple years ago maintaining a mod called "Subpar Survivors." I don't currently have the time to devote to maintaining something like this again, but as I said I'd be happy to help in some small way if needed.

Thanks, I haven't actually looked at the code from subpar survivors. I only noticed it was being referenced while skimming through the functions and found errors in the current workshop version referencing it. (That tipped me off about the code not completely being original).

For now, I'm trying to reduce the number of scanning operations that is being done right now (that is literally what is killing the performance).