Oxygen Not Included

Oxygen Not Included

Customize Plants
Crash relating to mutant CritterTrapPlantSeed
Getting a consistent crash that may or may not be associated with a mutant lura, judging by the logs? Would appreciate knowing if this is a situation where I should be changing mutation-related settings.

[13:45:29.692] [1] [ERROR] CritterTrapPlantSeed ~~~!System.NullReferenceException: Object reference not set to an instance of an object
at MutantPlant.UpdateNameAndTags () [0x0002f] in <3b73c925114143c5bad31ccbc5facdf1>:0
at MutantPlant.Analyze () [0x00007] in <3b73c925114143c5bad31ccbc5facdf1>:0
at CustomizePlants.MutantPlant_AnalyzePatch.Postfix (MutantPlant __instance) [0x00000] in <0e04d28afe1b401088bf5c3f886ea5a5>:0
at (wrapper dynamic-method) MutantPlant.MutantPlant.ApplyMutations_Patch1(MutantPlant)
at MutantPlant.OnSpawn () [0x0004c] in <3b73c925114143c5bad31ccbc5facdf1>:0
at KMonoBehaviour.Spawn () [0x0005d] in <7becb3f73037484c93dc2b548fe42a58>:0 !~~~Error in CritterTrapPlantSeed.MutantPlant.OnSpawn at (49.50, 114.01, -26.50)
[13:45:29.699] [1] [INFO] Customize Plants's assembly declared the method CustomizePlants.MutantPlant_AnalyzePatch:Postfix in the stack trace, adding to referenced mods list
~~~!System.NullReferenceException: Object reference not set to an instance of an object
at MutantPlant.UpdateNameAndTags () [0x0002f] in <3b73c925114143c5bad31ccbc5facdf1>:0
at MutantPlant.Analyze () [0x00007] in <3b73c925114143c5bad31ccbc5facdf1>:0
at CustomizePlants.MutantPlant_AnalyzePatch.Postfix (MutantPlant __instance) [0x00000] in <0e04d28afe1b401088bf5c3f886ea5a5>:0
at (wrapper dynamic-method) MutantPlant.MutantPlant.ApplyMutations_Patch1(MutantPlant)
at MutantPlant.OnSpawn () [0x0004c] in <3b73c925114143c5bad31ccbc5facdf1>:0
at KMonoBehaviour.Spawn () [0x0005d] in <7becb3f73037484c93dc2b548fe42a58>:0 !~~~Error in CritterTrapPlantSeed.MutantPlant.OnSpawn at (49.50, 114.01, -26.50)
< >
Showing 1-12 of 12 comments
When disabling the mutation analysis option, the crash still occurs, but the log no longer mentions Customize Plants, so I'm not sure if the crash is your mod or not? You'll certainly know better than me.

[14:09:21.587] [1] [ERROR] CritterTrapPlantSeed ~~~!System.NullReferenceException: Object reference not set to an instance of an object
at MutantPlant.UpdateNameAndTags () [0x0002f] in <3b73c925114143c5bad31ccbc5facdf1>:0
at MutantPlant.OnSpawn () [0x00052] in <3b73c925114143c5bad31ccbc5facdf1>:0
at KMonoBehaviour.Spawn () [0x0005d] in <7becb3f73037484c93dc2b548fe42a58>:0 !~~~Error in CritterTrapPlantSeed.MutantPlant.OnSpawn at (49.50, 114.01, -26.50)
~~~!System.NullReferenceException: Object reference not set to an instance of an object
at MutantPlant.UpdateNameAndTags () [0x0002f] in <3b73c925114143c5bad31ccbc5facdf1>:0
at MutantPlant.OnSpawn () [0x00052] in <3b73c925114143c5bad31ccbc5facdf1>:0
at KMonoBehaviour.Spawn () [0x0005d] in <7becb3f73037484c93dc2b548fe42a58>:0 !~~~Error in CritterTrapPlantSeed.MutantPlant.OnSpawn at (49.50, 114.01, -26.50)
Fumihiko  [developer] 24 Aug @ 12:27am 
That is a crash that happens, if you run an old version of the mod and disable the DLC.
Download[github.com] the mod and overwrite the files here C:\Users\%username%\Documents\Klei\OxygenNotIncluded\mods\Steam\1818145851
Will do, thanks. Steam being bad at updating mods as usual apparently.
Alright, I've tried replacing the contents of the specified folder twice, the first just cut and pasting and the second deleting everything in the folder entirely and unpacking the zip from your github release directly in there. The mod is showing up as v.1.0.50.0 in game in the mod menu. The crash is still occurring. Relevant log section (with auto analyse mutation disabled) as follows:

[15:23:06.480] [1] [ERROR] CritterTrapPlantSeed ~~~!System.NullReferenceException: Object reference not set to an instance of an object
at MutantPlant.UpdateNameAndTags () [0x0002f] in <3b73c925114143c5bad31ccbc5facdf1>:0
at MutantPlant.OnSpawn () [0x00052] in <3b73c925114143c5bad31ccbc5facdf1>:0
at KMonoBehaviour.Spawn () [0x0005d] in <7becb3f73037484c93dc2b548fe42a58>:0 !~~~Error in CritterTrapPlantSeed.MutantPlant.OnSpawn at (49.50, 114.01, -26.50)
~~~!System.NullReferenceException: Object reference not set to an instance of an object
at MutantPlant.UpdateNameAndTags () [0x0002f] in <3b73c925114143c5bad31ccbc5facdf1>:0
at MutantPlant.OnSpawn () [0x00052] in <3b73c925114143c5bad31ccbc5facdf1>:0
at KMonoBehaviour.Spawn () [0x0005d] in <7becb3f73037484c93dc2b548fe42a58>:0 !~~~Error in CritterTrapPlantSeed.MutantPlant.OnSpawn at (49.50, 114.01, -26.50)

Tested without Customize Plants enabled and was able to pass the cycle without the crash at the relevant point, so it does seem to maybe be something that still needs fixing? Unless I'm missing something. Also as far as I'm aware I have all DLC with none of them disabled, if that's relevant to anything.
Fumihiko  [developer] 24 Aug @ 12:32pm 
If you modify fruits, the mod will ensure that the plant has all the normal components (including mutations). However there are a couple of situations where this is bad. 1) if mutations are disabled (because the space DLC is not enabled). 2) the plant doesn't support mutations at all (like some plants which have special code or multiple parts).

I have fixed these issues. But you need to run the latest update. I get these conversations all the time. I had this exact conversion already. Most people get it working. And I cannot look into your PC, so I will just assume you are doing something wrong.

You can however also remove all fruit changes. Then the old version probably works too.
Can confirm: updated via the github link you provided, rather than via steam, or even mod updater.

I was about to write a long earnest message assuring you of this and offering to send screencaps as evidence, but based on your 'modifying fruits' comment, I tried temporarily removing my config file first. Worked like a charm. No more crash. Put my config back: crash returns. Again, this is on latest version and I can prove it if you want me to.

(Version marked '[1.0.50.0] U56-679336-SCRP' on github, correct? Commit 93d200a? If there's a version more recent than this, I can't see it at the link you provided.)

After more testing, it is specifically the lura part of the config that's crashing, which makes sense given the logs. If I remove it, the crashes stop. Here's the config:

{
"id": "CritterTrapPlant",
"fruitId": "PlantMeat",
"fruit_grow_time": 18000.0,
"fruit_amount": 10,
"irrigation": {
"Water": 10.000001
},
"safe_elements": [],
"temperatures": [
118.149994,
218.15,
358.15,
448.15
]
},


Generally, I never modify fruit, but I always change temperatures and any irrigation that isn't water. I'm happy just deleting the section since I don't even use lura plants at the moment, but if this isn't supposed to be happening on your current patch, I'm also fine to mess around with stuff for testing purposes if it would help you, since I have this handy save file where there's a problem seed about to drop. I did also preemptively get those screencaps of the in-game mod version number if you want me to send them anywhere.
Fumihiko  [developer] 25 Aug @ 7:33am 
yes https://github.com/Truinto/ONI-Modloader-SimpleMods/releases/download/r32/CustomizePlants.zip

I see that I haven't tested that plant specifically. So perhaps you are the first to try it. Guess this one needs to be excluded as well.
Yes, that's the one! But yeah, if your fix was regarding the butterfly plant specifically, might be that the lura plant is still a problem. I'll be happy to test any new versions on my convenient crashing save for you if it would be helpful!
Fumihiko  [developer] 26 Aug @ 10:52am 
Should be fixed
Thank you! Could you put it on Github when you have a chance, please? Steam is doing the customary failure to download the new version for me, more aggressively than usual.
Fumihiko  [developer] 28 Aug @ 7:49am 
Oh yeah, I forgot to click that button.
Can confirm my crashing save is no longer crashing with latest version, thanks for your update!
< >
Showing 1-12 of 12 comments
Per page: 1530 50