Library Of Ruina

Library Of Ruina

105 ratings
Cya's Assorted Fixes
   
Award
Favorite
Favorited
Unfavorite
Tags: Fix
File Size
Posted
Updated
1.515 MB
30 Oct, 2022 @ 12:38pm
30 Aug @ 3:41am
39 Change Notes ( view )

Subscribe to download
Cya's Assorted Fixes

In 1 collection by Cyaminthe
Fixes and QoL
25 items
Description
A selection of fixes, partially included in other mods, partially too specific to be grouped with anything else.

Currently includes fixes for:
- Deselected combat pages staying above their neighbours in hand (also included in Enhanced Combat Page View)
- Combat Pages in hand getting stuck in a state of being unable to perform the unselectability animation if hand was previously closed while the said pages were still performing the said animation (also included in Enhanced Combat Page View)
- OnApplyCard being called before OnReleaseCard when replacing a previously played page, causing special effects to be cancelled when a page was replacing itself (also included in Targetable Mass Attacks)
- Player characters only autotargeting the first speed die of enemies with a "last speed die is untargetable" passive (also included in Respectful Targeting)
- Autoplay breaking as soon as one of player characters fails to find a target (also included in Respectful Targeting)
- Both player- and enemy-side autoplays ignoring IsOnlyAllyUnit and IsValidTarget (also included in Respectful Targeting)
- "Ignore untargetability" effects (NotTargetableRemoved/NullifyNotTargetable) affecting even characters that are removed from combat (IsExtinction) (also included in Respectful Targeting)
- Modded page abilities not displaying keywords (also included in Compatibility Kit and Better Filters)
- Combat Page keywords defined innately in XML data instead of via scripts not being searchable or inheritable by copies (also included in Better Filters)
- Inability to play self-targeting pages when self is the only available target (also included in Trigrams Target Anything)
- As the full list of fixes has gotten too long to be included in a Steam Workshop item description, the rest of it can be read here[pastebin.com].
37 Comments
Cyaminthe  [author] 5 hours ago 
@A Terraria Mage
This is most likely a conflict with some other mod, since nothing of the sort was encountered in
pre-release testing. Can you provide your Player.log file to help diagnose the issue? It can be found in %appdata%\..\LocalLow\Project Moon\LibraryOfRuina .
A Terraria Mage 30 Aug @ 7:12pm 
Heya! I have no clue what the most recent update has done, but it causes a softlock every battle before even turn 1.
kaz_mighty 4 Mar @ 1:46am 
Thank you!
Cyaminthe  [author] 2 Mar @ 12:31pm 
@kaz_mighty
The issues with Greater Split: Vertical and DestroyCard variants have been fixed, as well as the issue with dice reuse in the Individual->Summation scenario.
The ability of destroyed pages to defend against Mass Attacks was argued to not be a bug and preserved due to public demand.
kaz_mighty 22 Feb @ 5:17am 
Due to the dice queue reset fix, Red Mist Great Split: Vertical can destroy used pages.

A related vanilla bug is that BattlePlayingCardSlotDetail.DestroyCard, DestroyCardByIdx, and DestroyCardWithoutCurrentAction don't check if a page has been used.
Also, pages destroyed by Mass-Summation etc. can be used to defend against Mass Attacks.
(If the dice are destroyed by Mass-Individual etc. they cannot be used.)
Additionally, the defender's current dice are not reset at the end of a Mass Attack, so a Mass-Summation attack into the same speed slot immediately after a Mass-Individual attack will reuse the last dice used.

(Personally, I think it would be more natural if destroyed pages and used pages could not be used to defend against a Mass Attack, just like destroyed dice.)
Cyaminthe  [author] 28 Jan @ 2:15pm 
@cinemote
Why are you commenting this on Assorted Fixes?
cinemote 28 Jan @ 12:44pm 
I don't understand how to use Targetable mass attacks. I double click on the speed die with the mass attack and nothing happens? Am I supposed to click-drag something?
Cyaminthe  [author] 26 Jan @ 9:14am 
@O.0
The part of the fix causing the issue has been temporarily disabled as a hotfix until a better solution is made.
O.0 26 Jan @ 3:48am 
When a single page can attack multiple enemies, it is not a group page and will continue to be used, this is a bug (sorry,I can‘t speak English)
kaz_mighty 25 Jan @ 7:22am 
Thank you! It worked fine.