I'll have to do a bit more digging to find the specific mod/item, cause I don't remember the item's name or what mod it comes from. I'll let you know when I do figure it out.

ah yeah that would be a mod conflict, paychests don't replace eternal chests, I guess a normal chest spawned and then this mod tried to turn it into a paychest and the other mod tried to turn it into an eternal chest both at the same time
what's the mod/item? might do a bit of testing

I just wanted to come here and say that this mod has issues with eternal chests, if the mod tries to force an eternal chest to become a pay chest, the eternal chest remains but interacting with it still consumes the player's gold, like some code for the pay chest is still running despite it not properly having become a pay chest.

Although, I encountered this bug when playing with another mod that has an item that forces all chests to become eternal chests, so take my words with a grain of salt.

you might be spawning it in with the wrong subtype (theres a 'full' subtype and an 'empty' subtype) , try spawn 5.99.1

nothing in console btw

this doesnt work. maybe because of conflict with other mods but whenever i spawn one in via the console, i cant interact with it even if i have coins and they disappear when i leave and reenter the room. might because of rgon? i would recommend updating this to work with rgon cause i really like this idea but im not willing to give up rgon lol

I've been checking both the pack version and the stand alone version of the mod and haven't noticed any problems, if people having issues could check their debug console by pressing ~ and see if there's any error messages that might help.

These are broken for me, after putting in the required amount of coins the chest glitches out and spams the opening sound but nothing comes out, after leaving the room the chest disappears and nothing is dropped.

my game is so broken i dont have to pay and the chests duplicate and spawn gold chests

and ALSO gold chests that come from chests can still become pay chests, and spam even MORE G/P chests.

if im not careful they spam and spawn until i re-enter the room, and bringing in a bunch of gold and pay chests.

EA loot box

have added a synergy for pay to play in AB+ to bring it closer to the Repentance implementation (and in Rep it just stops the random replacing since gold chests with pay to play are literally just pay chests anyway)
all paychests will only cost 1 coin while you have the item regardless of which version of the game you have

Hey now these really exist with Pay to Play lol

Can I suggest a tweak/compat added well to actually, add the ability for the mod Time Machine to work with this (would also make sense to be added to the beggar bundle you have) the other suggestion is to change the item pool that the pay chests pull from of instead of the golden chest pool change to the Shop/Secret Room pools since I personally affiliate these chests with greed.

updated this for repentance, should also now reveal contents with guppy's eye and able to be opened using bombs with broken padlock

Updated for reptence?

This is a very cool addition to the game. Once you've played with them, it becomes a wonder they weren't in there to start.

literally uses the gold chest spawn pool, gives whatever you would get if it were a gold chest instead

also out of curiosity do these use the gold chest drop pool? like, do they have a chance of spawning items?

this is what the spiked chests should be, nice mod

could just be your RNG, but you can always decrease their spawn rate if it keeps happening

Is it just me or do they appear a bit to often?

ah, yeah it seemed to sometimes have a frame of overlap between creating the reward chest and checking for chest conversions, wouldnt happen in the old version since everything used to happen sequentially, should be fixed now

Hey, you did it! Very nice! There's one more callback you may be interested in: MC_POST_GAME_STARTED passes you a savestate parameter, which is exactly the continuedRun flag you compute in your code.

Also, a new bug has cropped up. Your chests have a weird habit of giving me empty chests as rewards... My guess is the golden chests you spawn for payouts are getting caught in the replacement code, but I haven't looked into it too much.

thanks for the feedback, between work and uni I don't really get much time to go through and check my mods for stuff like this, I'm sure there's a lot that could be done for my mods (especially the older ones that were made back when the API had less features), suprised I never thought of using a 'fake' stat to trigger cache update before, will probably update later today.

Guess I can't do cool formatting in comments? Just pretend the tags parsed...

If you do decide to refactor your code a bit, these ideas should get you started:
[list]
[*]Put the collide/pay code in a MC_PRE_NPC_COLLISION callback. The game is already making distance checks for collison, so no need to do it again yourself. Plus, you can now specify a radius in entites.xml.
[*]Add a luck cache to all your trinkets. This will make them trigger a cache update (MC_EVALUATE_CACHE) when collected, which is a good place to alter probabilities and flags and things. Even though you're technically using a luck cache update, you don't necessarily have to alter luck! I use this trick all the time.
[/list]

I hope you don't take this the wrong way--I only go this in-depth for mods that I really like. I can't tell you how many times I've been in shitty runs with no keys, and one of your chests came along and gave me something useful!

Hey, just letting you know your code is really inefficient.
In general, if you find yourself writing:

[code]
local entities = Isaac.GetRoomEntities()
for i = 1, #entities do
[/code]

You're doing something wrong.

Right now your code is doing a lot of unecessary checks and math 60 times a second. It's simple math, but this stuff really adds up when you get a lot of mods running. You should try and use callbacks for most of this stuff; the only thing in this mod that shouldn't be in a callback is your key decrementing for the challenge.

agreed

Any chance you can make the pay chests themselves and the trinkets seperate? I like the mod but I'm not a fan of the trinkets

added data saving and console commands so people can adjust the spawn rates however they like

i think the trinket sprites are too big. The should be smaller.

cool idea, but they show up too much...

i hope this enter in the next booster pack

The chests are WAY too common. I don't know if it is bad luck but essentially every chest I see now is a pay chest with the occasional stone ones. I've only seen 1 gold and 0 normal chests since downloading this.

can you make a verson with just the chests

Maybe you should change your challenge name to "Pay Up"

have changed how chests treat luck, now the higher your luck the more likely the chests cost will be lowererd, still with a minimum of 2 (and a maximum of 7 if you have negative luck), mathmatically speaking having say 7 luck makes it impossible for a chest to cost 7 and unlikely to cost 6, while 10+ luck brings the highest possible cost down to 5,
(and 15+ for 4 and 20+ for 3, max cost won't go lower than 3)

not that you need 10 luck to have chests typically cost 5 or less, just that if you have less than 10 luck there's always a chance a chest could cost 6

Really cool. Only (minor) criticism is that they seem to show up waaaayyyy too often, even without the trinkets you added.

could you make it to pay max to 5? 7 is kinda not worth the content most of the time, even with mom's key sometime it doesn't pay well

I vote this for implementation in the next booster pack

chests should no longer turn into paychests if the player has the left hand trinket

the trinket "the left hand" does not replace pay chests to red chests, is this normal?

we need this in the game
vote it up

Oh, I misread, sorry!

Kalamari Octopy, you might have skipped the first part of that paragraph, it replaces those types of chests

There's already a trinket for red chests, the left hand: http://bindingofisaacrebirth.gamepedia.com/The_Left_Hand

And you don't have a trinket for stone chests?

this is how a good idea looks like