@Tangent Logic
Can you share in what instances you aren't seeing the mod working as it should?

latest version it no longer works

Issue was related to the character trying to store a ranged weapon which they could not equip while not having any ranged weapon equipped, since the logic avoids storing their best ranged weapon, this was causing a conflict when trying to find the best ranged weapon in their inventory.

@NPOu
From memory, nothing unusual. Her equipped gear, a Putit in Amber, maybe some purchased food, and some textiles loot. Nothing seemed unusual (for Elin, anyway), other than the fact she wouldn't dump it like every other companion or resident. Sadly don't have a backup with her anymore, either. Sorry, can't provide anything of use there.

I'm gonna try picking her up again, and if the NREs come back I'll prepare an upload.

@Zuleyus
Do you know what specific items she was carrying?

@NPOu
Sorry for not getting back to you any sooner, life and all that.

OTOH, I realized that the NRE spam was limited to a specific character only. I also noticed that she wouldn't drop her carried stuff into the home base containers as the other pets do. Something must have broken specifically with her; soon as I banished her the NREs stopped altogether. Haven't tried picking her back up again yet, so can't tell if that fixed the character. It was one of the leaderboard adventurers, Lazbed the fairy priestess (not sure if the lower ranks are also fixed names or randomized). Sucks to see her go, my healing output dropped noticeably without her.

@Zuleyus
Residents will only put things in placed shared containers so yes, unlikely you'll see it anywhere else, however, I cannot reproduce the issue.
I added a couple more null checks but it's a shot in the dark. If possible share your save file with me on Discord, you can message Balrog8655 on Elin's discord.

@NPOu
At the home base only, but there it's constantly spammed, likely on every single container query (only placed ones? not sure, but highly likely given it doesn't appear in nefias). It became especially apparent after adding Unity Explorer with the exception notification, instead of just glancing at the log every once in a while.

Traces are all pretty much the same, ending at the .Postfix_TryPutSharedItems, otherwise I'd have prepared a full log upload for you already.

@Zuleyus
Didn't notice this notification, sorry.
In what cases are you getting the errors? Or is it all the time?

Confirmed to still throw NREs with only this mod, Mod Options, Mod Config GUI, CWL, and Unity Explorer enabled. Also causes screen flashing for me, which I understand is a common issue with Elin and mod problems.

Removed object GUIDs for Steam's 1k char limit. These NREs don't seem to create gameplay issues, but something is obviously working less than optimal.

Help me Senpai, you are spamming my log with tons of NREs (confirmed to go away with disabling the mod)

NullReferenceException: Object reference not set to an instance of an object
at Patcher.Patch.Postfix_TryPutSharedItems (System.Collections.Generic.IEnumerable`1[T] containers, System.Boolean msg, System.Boolean shouldEat, Chara __instance) [0x00177] in <...>:0
at (wrapper dynamic-method) Chara.DMD<Chara::TryTakeSharedItems>(Chara,System.Collections.Generic.IEnumerable`1<Thing>,bool,bool)
at Chara.TryTakeSharedItems (System.Boolean msg) [0x00006] in <...>:0
at AI_Idle+<Run>d__10.MoveNext () [0x0068b] in <...>:0
at AIAct.Tick () [0x000a5] in <...>:0
at AIAct.Tick () [0x0002c] in <...>:0
at Chara.Tick () [0x0068d] in <...>:0
at GameUpdater+CharaUpdater.FixedUpdate () [0x00065] in <...>:0
at GameUpdater.FixedUpdate () [0x000aa] in <...>:0
at Game.OnUpdate () [0x00086] in <...>:0
at (wrapper dynamic-method) Core.DMD<Core::Update>(Core)

All functions are now working well together.
Thank you for your help.

Also, ResidentsDoNotWaste https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=3389920359 completely blocks sale/destruction of items, by gifts or not.

@KissDiamond
Throwing/ranged weapons are never sold/destroyed by your resident or pets, this is checked first before checking if the item is gifted or not (they can sell gifts which they don't have equipped), it's base game behavior, so that problem shouldn't exist.

In the game, gifted items can be sold by companions.
Will the gifted throwing weapons also be sold by them?

@KissDiamond
I have 2 mods that'll solve your problem:
AcceptMoreGifts https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=3393596869
GiftedEquipmentPriority https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=3393701894
One lets you gift throwing weapons, the other prevents characters from taking more throwing weapons into their inventory even if they don't think the one they have is the best one.
This mod (ResidentsShareFindings) by default already doesn't let characters dump gifted items, so all you need to do is gift the throwing weapons.

They lack Marksman, Bow, Crossbow and Gun skills, resulting in low accuracy, so they use throwing weapons instead

@KissDiamond
I'll test later but aren't they taking guns? It's possible they think those are better.
I'm planning to make a mod that overwrites some rules to stop pet dumping or changing equipment that'd let you pick their throwing weapon but might take a few days.

DumpInventory = true

Boomerang, Mic, and Putit in Amber will be dumped.

@KissDiamond
I can but the best throwing weapon is already ignored (otherwise they'd take it back). They won't use more than 1 (actually they'll dump their other weapons as part of base game behavior if they find a better throwing weapon).
What issue are you facing?

Can you add a condition to ignore the following items when dumping them?

Throwing weapons

TraitThrown and TraitToolMusicMic

I added an option for pets to no longer dump things they own if people think that's cheating and just want to use this mod together with PetsTakeMoreItems for automatic pet dumping.

mod机翻：居民/宠物将把他们找到的物品（标记为自己拥有的）放在共享容器中。
它们会被标记，但一旦你把它们放入你的库存中，它就会消失，这也让你知道一个居民给了你什么。
有一个设置（默认关闭），也让居民/宠物倾倒他们的整个库存，而不仅仅是他们自己的东西，在共享容器中，这将让你的宠物倾倒库存，当你在家，而不是你不得不把东西拿回来时。
在所有情况下都有例外，以避免给予-拿走我们不应得/不想要的东西：
-天赋/装备物品/货币/工具(如吟游诗人,的工具，不被视为他们的财产）/有特定标签的物品（例如商人的箱子）
除此之外，一些居民也会从稀薄的空气中生成物品，这是他们的财产，现在mod涵盖了这些情况：
可以阅读书籍的居民有能力生成随机书籍。为了避免mod过于欺骗，你可以配置他们试图倾倒物品的频率。

Actually, I got a secretary and did a bit of testing, it seems more like they spawn a book and keep it, other NPCs read it right away, but later on they can read the book, but issue seemed to be that they were dumping it faster than they were reading.
Anyway adding a random check to see if they dump it or not will balance/fix it.

Outside of that, I'm not seeing anyone who'd idly create things out of nowhere.

@DawnOfWolfy
@Cat Of War
Any of these NPCs will read books and thus generate them:
secretary
secretary
scholar of history
suffering apprentice
book shopkeeper
scholar
chief of orphanage
seeker
guild clerk
guild clerk
naughty book shopkeeper
Cursed Girl
casino clerk
guild clerk
Outside of doujin books they'll read the book... except if they are in the player's faction, then they just only generate 1 book and keep it forever. Only members of your party actually read the books (and only if they are gifted).
I guess this is to avoid your secretary gaining all the skills (but others are ok?)
I could make an exclusion but similar to the instruments for bards, it's kinda the point of this mod?
I'll make it a low chance for them to deposit their items instead of outright excluding it.

It might be due to NPC's like secretaries, who will frequently spawns books out of the void to read.

@Cat Of War
Unfortunately I don't have every type of resident to test so could have unexpected results...
Are you using along with ResidentsDoNotWaste too?
If you could also send me your save through Discord that'd be great (you can search for Balrog on Elin discord).

Good mod but for some reason im getting an insane amount of books. I have to turn it off because they put so many books in my bookshelves