RimWorld

RimWorld

Refactored Work Priorities (Continued)
32 kommentarer
Mlie  [ophavsmand] 21. sep. kl. 5:26 
@mischab1 Should be fixed now
mischab1 20. sep. kl. 15:56 
@Mlie - Are those changes you made uploaded to Steam? Because the Incompatible with PUAH flag is still there.
Mlie  [ophavsmand] 31. aug. kl. 12:35 
@ZzZombo Made some changes to the code, tested it with PUAH and noticed no issues now
ZzZombo 27. aug. kl. 0:16 
Note I have no hard evidence this is actually caused by PUAH, just a guess.
ZzZombo 27. aug. kl. 0:11 
@Mlie: I think I figured it out.

> Hoffelmaw threw exception in WorkGiver HaulDeteriorating: System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.Collections.Generic.HashSet`1+Enumerator[T].MoveNext () in
<...>
at RimWorld.JobGiver_Work.TryIssueJobPackage (Verse.Pawn pawn, Verse.AI.JobIssueParams jobParams)

I think PUAH causes modifications to the underlying hash set due to its very nature which this mod's work giver returns as the potential work thing list. This invalidates the enumerator and is disallowed by the BCL. I suggest to store the `enumerable` into a temporary array and work on it. Also, in the case the map is `null`, the code sets `enumerable` to null, but subsequently attempts to call methods on it. Just return `Array.Empty<Thing>()` in this case.
Mlie  [ophavsmand] 22. aug. kl. 22:34 
@ZzZombo No idea, there has been no detailed explanation yet. Just reports
ZzZombo 22. aug. kl. 19:44 
What exactly breaks with PUAH and this mod running?
Terzetto 18. aug. kl. 19:24 
I'm not ever using this mod and I want to let you know Miles, you are a real one.
Mlie  [ophavsmand] 13. juli kl. 20:43 
@-BNH-TheBird Please post the link to the mod you want to request in the mod-requests channel of the Discord server as this saves me a lot of admin-time.
-BNH-TheBird 13. juli kl. 14:17 
Work Manager could also use an update to 1.6, thanks for doin these btw
Mlie  [ophavsmand] 25. jan. kl. 10:46 
@weregamer I never plyed the 0.18 version that this is based on so cant say.
But the incompatibility was reported here below as you can see
weregamer 25. jan. kl. 10:37 
The game flags this as incompatible with PUAH. I don't remember that being true before, is the game correct?
SimplePhysics 17. juli 2024 kl. 10:06 
I'll add my etheral support for hoping a later update makes this compatible with PUAH
lol 26. apr. 2024 kl. 11:00 
@Amroth same here
Amroth 4. feb. 2024 kl. 9:59 
As much as I like the mod, have to reluctantly let it go. Pick Up & Haul is too essential to choose over this ;/
Mlie  [ophavsmand] 8. nov. 2023 kl. 10:44 
@lol Added incompatibility tag for it
lol 7. nov. 2023 kl. 9:30 
Unfortunately, this mod seems to be incompatible with Pick Up And Haul, at least currently.
IIFriggII 7. feb. 2023 kl. 8:34 
maaan this mile's dude is awesome. so many good mods still exist bc of him TYVM big star :D
butanefireflies 22. okt. 2022 kl. 11:32 
Hey Mlie, thanks for your expansive efforts. 1.4's quick loading time finally convinced me to track down why Pick Up and Haul doesn't work, and it turns out that it breaks when used in conjunction with this mod. No error log, but I tested it on an otherwise empty mod list and tried both load orders. I'm sure you've got plenty of other work to do, and it might be an overly-difficult fix, but I figured I'd let you know :)
Mlie  [ophavsmand] 7. nov. 2021 kl. 11:50 
@DisKorruptd No, that mod uses its own repair logic and jobs so I cant really force it from what I can tell
DisKorruptd 7. nov. 2021 kl. 11:38 
With Repair Items, does the designator hit items below threshold too?

https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=2564355300
Lurmey 18. juli 2021 kl. 6:07 
Hey Mlie, couple suggestions:

- Harvesting grown plants should probably be higher than sowing them.
- Planting in plant pots as opposed to grow zones and hydroponics (or grow boxes) should be a separate lower priority workgiver.

Thanks for maintaining these great mods :)
Lurmey 28. juni 2021 kl. 14:00 
Also whenever I manually prioritise hauling they won't use PUAH. I wonder if Jobs of Opportunity is messing with it. I'll try disabling the PUAH compat with that tomorrow and test.
Lurmey 28. juni 2021 kl. 13:59 
Ah, I wonder why my colonists aren't using it then? The only haul perishable/rottable thing I have is from this mod and when I prioritise hauling jobs (via Colony Groups) they all only haul one stack at a time.
Mlie  [ophavsmand] 28. juni 2021 kl. 13:14 
@Lurmey PUAH should work as normal I think since it uses the low-prio hauling task and not the priority ones.
Lurmey 28. juni 2021 kl. 13:12 
Hey Mlie, do you know if the "Haul deterioratables" and "Haul rottables" settings in this mod activate Pick Up and Haul when present? If not could you perhaps look into adding that if it's not too much trouble? PUAH is a must-have!
D_F_N 17. feb. 2021 kl. 5:31 
Thank you Mlie!
Mlie  [ophavsmand] 17. feb. 2021 kl. 5:19 
@D_F_N Seeing that that mod just got released I havent tested it but judging from the description I should say no. This mod just prioritizes removing roofs before building roofs. The other mod seem to block removing roofs if it would mean that the roof would have collapsed.
D_F_N 17. feb. 2021 kl. 5:15 
Is the "removing roofs" setting the same behavior as the mod https://gtm.steamproxy.vip/sharedfiles/filedetails/?id=2398365712 ?
Mlie  [ophavsmand] 19. maj 2020 kl. 1:19 
@Crymson Fluffsune Ill look into it
FlareFluffsune 19. maj 2020 kl. 0:50 
Hey. Absolute thanks for all the effort you're putting into reviving these mods, is there any chance you can put a brief description in the first line for hover over in the workshop instead of "Update of X" so people can get a quick idea of what the mod does without having to navigate to the page to find out?
Nemo 17. maj 2020 kl. 15:09 
Mate, just wanted to say thank you for updating all these mods, you're a credit to the community.