Weather has some impact on battles.
Foggy weather will cause you to have reduced visibility of enemy units.
Rain and snow will make it take longer to set buildings and towers ablaze.

I haven't noticed much impact from hills. There does not seem to be any uphill penalties or downhill bonuses to charge or anything like that.

Terrain does affect line of sight for ranged units. Being on the top of a hill is easier in that regard.